public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] xilinx FPGA code
@ 2007-11-12 18:27 Andrew Dyer
  2007-11-12 19:19 ` Matthias Fuchs
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Dyer @ 2007-11-12 18:27 UTC (permalink / raw)
  To: u-boot

A couple of "IMHO" comments about this code in no particular order:

Is there any reason to have spartan2.c, virtex2.c and spartan3.c? They
are pretty much copies of each other with search and replace.

local PRINTF should be replaced with the global 'debug' macro.

this issue behind this patch should be addressed (relocating null pointers)
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/22918

I believe the edict was given by wd@ that CFG_HZ was always to be
1000, and delays can be spec'd in units of ms rather than based off of
CFG_HZ

could do with some whitespace cleanup & reformatting to 80 cols.

-- 
Hardware, n.:
        The parts of a computer system that can be kicked.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-12-03 11:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-12 18:27 [U-Boot-Users] xilinx FPGA code Andrew Dyer
2007-11-12 19:19 ` Matthias Fuchs
2007-11-13  7:15   ` [U-Boot-Users] Help Loading I.MX21 Demetris Zavorotnichenko
2007-12-03 11:04     ` Midhun A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox