From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Thu, 15 Nov 2007 12:02:48 -0600 Subject: [U-Boot-Users] [PATCH] Enable ULi1575 Ethernet support in 8610HPCD config In-Reply-To: <473C51A3.7020501@freescale.com> References: <1194979793.12888.27.camel@ld0161-tx32> <473B13D9.2050400@freescale.com> <473B24EA.1030804@freescale.com> <1195122629.7336.3.camel@localhost.localdomain> <473C51A3.7020501@freescale.com> Message-ID: <20071115180247.GA4441@loki.buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Nov 15, 2007 at 08:03:15AM -0600, Timur Tabi wrote: > Zang Roy-r61911 wrote: > > > I intend to keep RTL8139 and Intel EEPR100. They work on the board and > > can provide extra choices except the on board Ethernet port. Is there any reason one wouldn't want to use the on-board ethernet port? > Well, the board config files should match what's on the board. We don't > ship the board with an RTL or Intel NIC, therefore the config file should > not enable them. With your logic, we should just enable ALL of the NICs > that work. > > If a customer inserts an RTL or Intel NIC, he can add those lines if he > wants. Otherwise, all you're doing is bloating the binary. Hmm, weren't you scrounging around for a certain kind of PCI NIC that your 8610 board's u-boot image supported not too long ago? Wouldn't it have been nice if they built in support for a few of the most common ones? :-) -Scott