From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Sun, 18 Nov 2007 17:28:29 +0100
Subject: [U-Boot-Users] [PATCH] Fix u16 status declaration when
	PCMCIA	is defined
In-Reply-To: <20071118152751.B8783243A9@gemini.denx.de>
References: <1195386902-15477-1-git-send-email-plagnioj@jcrosoft.com>
	<20071118152751.B8783243A9@gemini.denx.de>
Message-ID: <20071118162829.GA4286@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 16:27 Sun 18 Nov     , Wolfgang Denk wrote:
> In message <1195386902-15477-1-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > 
> > diff --git a/board/pb1x00/pb1x00.c b/board/pb1x00/pb1x00.c
> > index 95b7d82..536c954 100644
> > --- a/board/pb1x00/pb1x00.c
> > +++ b/board/pb1x00/pb1x00.c
> > @@ -42,7 +42,9 @@ void write_one_tlb( int index, u32 pagemask, u32 hi, u32 low0, u32 low1 );
> >  
> >  int checkboard (void)
> >  {
> > +#if defined(CONFIG_IDE_PCMCIA) && 0
> 
> Oops? What is the meaning of the "&& 0" here ???
> 
> There are less cryptic ways to comment out a line of code, it seems.
> 

I agree, but I've chose the same that the line 78.

If you prefer I can as fallowing

#if 0
#if defined(CONFIG_IDE_PCMCIA)

...

#endif
#endif

Best Regards.
J.