From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
Date: Mon, 19 Nov 2007 11:04:21 +0100
Subject: [U-Boot-Users] flash hardware protection with CFI driver does
	not autoprotect monitor completely
In-Reply-To: <200711190714.45200.sr@denx.de>
References: <20071118215200.67EAA243A9@gemini.denx.de>
	<200711190714.45200.sr@denx.de>
Message-ID: <200711191104.21853.matthias.fuchs@esd-electronics.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On Monday 19 November 2007 07:14, Stefan Roese wrote:
> On Sunday 18 November 2007, Wolfgang Denk wrote:
> > > > I think as a short term fix we might define an additional  area  that
> > > > needs  to  be  protected  (the reset vector). Mid/long term we should
> > > > change the code so you  can  pass  a  list  of  areas  (start/end  or
> > > > start/length  pairs) that will be protected. This would, for example,
> > > > also allow to keep certain other  areas  (FDT,  kernel  image,  etc.)
> > > > auto-protected as well - configurable by the user ona per-board base.
> > >
> > > Sometinhg like this?
> > >
> > > Add this to board's config file:
> > > #define CONFIG_FLASH_AUTOPROTECT_LIST {{0xfffe0000, 0xffffffff},
> > > {0xfe000000, 0xfe0fffff}}
> >
> > Yes, that's what I meant, although I have to admit that my personal
> > preference would be to use { start, size }  instead.
> >
> > What do you (and others) think?
I am passionsless. So I vote with the majority.
> 
> Yes, I would prefer size too. This would lead to something like this on 4xx 
> boards:
> 
> #define CONFIG_FLASH_AUTOPROTECT_LIST { {CFG_MONITOR_BASE, CFG_MONITOR_LEN} }
This looks fine and I will start voting for this, too.

I am wondering if it is possible to get rid of the current autoprotection
code (3 x flash_protect for monitor, env and 2nd env) in drivers/cfi_flash.c 
and fully implement it through the AUTOPROTECT_LIST without modifyiny all 
board config files. Any nice idea?

Especially on 4xx when you like to have sometinhg like

#define CONFIG_FLASH_AUTOPROTECT_LIST { {CFG_MONITOR_BASE, CFG_MONITOR_LEN} }

in your config file you will flash_protect most of the bootloader flash space twice.

Matthias