From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH][RFC] Add common memory fixup function
Date: Tue, 27 Nov 2007 13:11:04 -0600 [thread overview]
Message-ID: <20071127191104.GA4472@loki.buserror.net> (raw)
In-Reply-To: <47F3F98010FF784EBEE6526EAAB078D1024F8805@tq-mailsrv.tq-net.de>
On Tue, Nov 27, 2007 at 09:13:06AM +0100, Martin Krause wrote:
> Kumar Gala wrote on Monday, November 26, 2007 9:56 PM:
> > + addrcell = fdt_getprop(blob, 0, "#address-cells", NULL);
> > + if ((addrcell) && (*addrcell == 2)) {
> > + for (i = 0; i <= 7; i++)
> > + tmp[i] = (start >> ((7 - i) * 8)) & 0xff;
> > + len = 8;
> > + } else {
> > + for (i = 0; i <= 3; i++)
> > + tmp[i] = (start >> ((3 - i) * 8)) & 0xff;
> > + len = 4;
> > + }
>
> Could this perhaps lead to endianess issues under some special
> circumstances?
I don't think so -- the device tree is defined as always being big-endian,
regardless of the host endianness (multi-cell values would get a bit weird
otherwise).
-Scott
prev parent reply other threads:[~2007-11-27 19:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 20:55 [U-Boot-Users] [PATCH][RFC] Add common memory fixup function Kumar Gala
2007-11-26 22:12 ` Vitaly Bordug
2007-11-26 22:23 ` Kumar Gala
2007-11-27 0:15 ` Vitaly Bordug
2007-11-27 8:38 ` Martin Krause
2007-11-27 8:04 ` Martin Krause
2007-11-27 8:13 ` Martin Krause
2007-11-27 19:11 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071127191104.GA4472@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox