From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 29 Nov 2007 07:24:10 +0100 Subject: [U-Boot-Users] [PATCH] NET: Proper return code handling in eth_init() function in file eth.c In-Reply-To: References: Message-ID: <200711290724.11234.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 29 November 2007, Upakul Barkakaty wrote: > NET: Proper return code handling in eth_init() function in file eth.c > > This patch modifies the return code handling in the eth_init() > function, to be compatible with the handling of the return codes in > the other network stack files. It now returns a 0 on Success and -1 on > error. > > Signed-off-by: Upakul Barkakaty > > diff -Naur a/net/eth.c b/net/eth.c > --- a/net/eth.c 2007-11-26 09:53:55.000000000 +0530 > +++ b/net/eth.c 2007-11-26 10:55:59.000000000 +0530 > @@ -404,23 +404,23 @@ > struct eth_device* old_current; > > if (!eth_current) > - return 0; > + return -1; > > old_current = eth_current; > do { > debug ("Trying %s\n", eth_current->name); > > - if (eth_current->init(eth_current, bis)) { > + if (!eth_current->init(eth_current,bis)) > + { Don't move the "{" into the next line. Please change this and resend the patch. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================