From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 11 Dec 2007 23:05:37 +0100 Subject: [U-Boot-Users] [PATCH 4/6] cfi_flash: Introduce read and write accessors In-Reply-To: Your message of "Tue, 11 Dec 2007 18:13:17 +0100." <20071211181317.7a9abc4e@dhcp-252-066.norway.atmel.com> Message-ID: <20071211220537.586B5246C2@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <20071211181317.7a9abc4e@dhcp-252-066.norway.atmel.com> you wrote: > > > Kumar is right. We definitely must use the "real" accessor functions. > > Yeah, I agree too. > > From a quick glance, m68k, powerpc, nios and nios2 lack these > functions. Anything special I need to know about those architectures, > or should I just grab them from Linux or use volatile? Grabbing the code from Linux is fine with me; we must test this extensively in any case. But I would not reject the patch if you made life easy for you and just used volatile for these archs. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Life and death are seldom logical." "But attaining a desired goal always is." -- McCoy and Spock, "The Galileo Seven", stardate 2821.7