[U-Boot-Users] [PATCH 6/6] cfi_flash: Use map_physmem() and unmap_physmem()

Haavard Skinnemoen
2007-12-12T09:36:32Z

On Tue, 11 Dec 2007 19:49:26 +0100
Stefan Roese <sr@denx.de> wrote:

> When starting something like map_physmem(), we should consider the following
> things:
>
> - Some platforms have >32bit physical address space, like PPC440 with 36bits.
> So the type of phys_addr should not be fixed to u32. We need a new typedef
> here. And/or perhaps something like the resource stuff from Linux.

Yeah, we probably need a typedef. How about phys_addr_t or something?

I can cook up a patch adding phys_addr_t typedef'd as unsigned long on
all architectures. If someone wants something different, please let me
know.

> - We should add a size parameter

Absolutely.

> - And a "flags" parameter as mentioned above would make sense too, for stuff
> like caching etc.

Agreed. Platforms are of course free to ignore these extra parameters.

Haavard