From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 19 Dec 2007 14:02:15 +0100 Subject: [U-Boot-Users] fdt chosen node handling In-Reply-To: <47690D64.2030704@ge.com> References: <200712190859.54306.sr@denx.de> <47690D64.2030704@ge.com> Message-ID: <200712191402.16155.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jerry, On Wednesday 19 December 2007, Jerry Van Baren wrote: > Disclaimer: I am not a OF expert, I have not read the OF documentation > cover to cover and do not understand many implications of what I've > read, much less what I have _not_ read. > > 1) I believe the /chosen node should be auto-created. Ufff. :) > 2) As you point out, if the /chosen node already exists the current code > bails out and doesn't change anything. This was done as a very badly > misguided attempt to make libfdt things work like bd_t things. The > granularity should be on the individual properties, not on /chosen. I > consider this a bug and have it on my "todo" list to fix (actually, I > had created a patch, but I need to rebase and publish it). > > > > "Unpublished patch of JerryVanBaren, implementing a suggestion by Scott > Wood to make the /chosen handling finer grained: if the /chosen node > exists, currently u-boot-fdt bails out. A better methodology is to not > overwrite pre-existing properties on a per-property basis, so if /chosen > exists but a necessary /chosen/property doesn't, it gets created. Good > idea, but not published and poorly tested at the moment." OK, thanks for these infos. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================