From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Thu, 27 Dec 2007 01:05:34 +0100
Subject: [U-Boot-Users] Pull request: u-boot-freebsd
In-Reply-To: Your message of "Mon, 17 Dec 2007 13:06:42 +0100."
	<47666652.30600@semihalf.com>
Message-ID: <20071227000534.69AA024889@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Rafal,

in message <47666652.30600@semihalf.com> you wrote:
> 
> This is a re-spin on the already requested pull for the initial implementation
> of the extended API for standalone apps, that is used for FreeBSD bootstrapping.

I'm afraid I have to reject this pull request.

First, I think it breaks Linux booting support for a couple of boards
(all 4xx ones, that is).

> The following changes since commit 41be969f4957115ed7b1fe8b890bfaee99d7a7a2:
>   Wolfgang Denk (1):
>         Release v1.3.1
> 
> are available in the git repository at:
...
>       [POWERPC] Simplify bd_info struct

This is the culprit.

With your  patch,  you  *always*  include  an  entry  "unsigned  long
bi_bar;" in the bd_infor structure - even for processors which didn't
have  one before (like 4xx boards). Thus you change the layout of the
bd_info structure for such systems, which causes  an  incompatibility
with the respective structure used by the Linux kernel.

Also, I have to admit that  I  dislike  this  type  of  #ifdef  based
"simplification".  I  don't  think  the  resulting  code becomes more
readable.

Please fix and resubmit.

Then, we have this part:

>       [Net] Introduce standalone eth_receive() routine

This adds a lot of code to the networking code which is not neede dby
most of the boards. Please make this an optional feature that get's
only compiled in for boards that explicitely request it. Then run this
patch separately through the network custodian.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Success in marriage is not so much finding the right person as it  is
being the right person.