[U-Boot-Users] [PATCH 1/3 RESEND] ppc4xx: Add initial esd PMC440 board files

[Matthias Fuchs <matthias.fuchs@esd-electronics.com>]

Hi Stefan,

the '--find-copies-harder' option would be more usefull when the patch would contain
a reference to commit id it is based on. So let's say a stable U-Boot relase tag.

Smaller patches are not everyting that counts in my opinion.
diff'ing against an existing file does not really help in understanding what
Matthias is doing in his code.

Even x-mas wishing time is over, we still have a chance for a new year present - 
Let's say a 100k size limit in 2008. 

(Won't duck)
Matthias

On Friday 28 December 2007 13:11, Stefan Roese wrote:
> Hi Matthias,
> 
> On Friday 28 December 2007, Matthias Fuchs wrote:
> > This patch adds the first files for the new esd PMC440 boards.
> > The next two patches will complete the PMC440 board support.
> >
> > Signed-off-by: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
> > ---
> >  board/{amcc/sequoia => esd/pmc440}/Makefile        |    4 +-
> >  board/{amcc/sequoia => esd/pmc440}/config.mk       |    0
> >  board/{amcc/sequoia => esd/pmc440}/init.S          |   64 +--
> >  .../sequoia/sequoia.c => esd/pmc440/pmc440.c}      |  564
> > +++++++++++++++----- board/esd/pmc440/pmc440.h                          | 
> > 154 ++++++
> >  board/{amcc/sequoia => esd/pmc440}/sdram.c         |    0
> >  board/{amcc/sequoia => esd/pmc440}/sdram.h         |    0
> >  board/{amcc/sequoia => esd/pmc440}/u-boot-nand.lds |    0
> >  board/{amcc/sequoia => esd/pmc440}/u-boot.lds      |    0
> >  9 files changed, 595 insertions(+), 191 deletions(-)
> >  copy board/{amcc/sequoia => esd/pmc440}/Makefile (95%)
> >  copy board/{amcc/sequoia => esd/pmc440}/config.mk (100%)
> >  copy board/{amcc/sequoia => esd/pmc440}/init.S (71%)
> >  copy board/{amcc/sequoia/sequoia.c => esd/pmc440/pmc440.c} (57%)
> >  create mode 100644 board/esd/pmc440/pmc440.h
> >  copy board/{amcc/sequoia => esd/pmc440}/sdram.c (100%)
> >  copy board/{amcc/sequoia => esd/pmc440}/sdram.h (100%)
> >  copy board/{amcc/sequoia => esd/pmc440}/u-boot-nand.lds (100%)
> >  copy board/{amcc/sequoia => esd/pmc440}/u-boot.lds (100%)
> 
> This option you used to make the patches smaller (find-copies or something 
> like this) really makes reviewing not easy. And additionally the patch 
> doesn't apply anymore, since the reference (sequoia) has changed in my non 
> publiched branch already. Another reason why I would like to see a 100k size 
> limit on this list.
> 
> So Matthias, could you please resend these 3 patches without this option to me 
> directly?
> 
> Thanks.
> 
> Best regards,
> Stefan
> 
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
> 
> 

-- 
-----------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs             esd electronic system design gmbh
http://www.esd-electronics.com                    Vahrenwalder Str. 207
phone: +49-511-37298-0, fax: -68                30165 Hannover, Germany
-----------------------------------------------------------------------