[U-Boot-Users] [PATCH] ppc4xx: More cleanup for esd's LCD code

[Wolfgang Denk <wd@denx.de>]

In message <200801021055.17023.matthias.fuchs@esd-electronics.com> you wrote:
>
> -	} else {
> +	} else
>  		/*
>  		 * Uncompressed BMP image, just use this pointer
>  		 */
>  		dst = (uchar *)logo_bmp;
> -	}

I object against this change. The "else" without curly braces is good
only if a simple one-liner is following.

Here you have 4 lines, and I definitely want to see braces here.


Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Yes, it's a technical challenge, and  you  have  to  kind  of  admire
people  who go to the lengths of actually implementing it, but at the
same time you wonder about their IQ...
         --  Linus Torvalds in <5phda5$ml6$1@palladium.transmeta.com>