[U-Boot-Users] [PATCH] ppc4xx: More cleanup for esd's LCD code

[Matthias Fuchs <matthias.fuchs@esd-electronics.com>]

Well, I even like braces around single lines:-) I only removed them in this 
case as a new years offering. 

Updated patch follows.

Matthias

On Wednesday 02 January 2008 11:28, Stefan Roese wrote:
> On Wednesday 02 January 2008, Wolfgang Denk wrote:
> > In message <200801021055.17023.matthias.fuchs@esd-electronics.com> you 
> wrote:
> > > -	} else {
> > > +	} else
> > >  		/*
> > >  		 * Uncompressed BMP image, just use this pointer
> > >  		 */
> > >  		dst = (uchar *)logo_bmp;
> > > -	}
> >
> > I object against this change. The "else" without curly braces is good
> > only if a simple one-liner is following.
> >
> > Here you have 4 lines, and I definitely want to see braces here.
> 
> Right. Please only remove the curly braces if only one line follows. Comments 
> and multi-line statements should also be put into the braces.
> 
> Thanks.
> 
> Best regards,
> Stefan
> 
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
> 
> 

-- 
-----------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs             esd electronic system design gmbh
http://www.esd-electronics.com                    Vahrenwalder Str. 207
phone: +49-511-37298-0, fax: -68                30165 Hannover, Germany
-----------------------------------------------------------------------