From: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] /* inside comment in libfdt.h
Date: Wed, 2 Jan 2008 13:46:59 +0100 [thread overview]
Message-ID: <200801021347.01153.matthias.fuchs@esd-electronics.com> (raw)
Hi,
I just tested the current master branch after Wolfgang recent custodian merge
and noticed some errors that are caused by comments inside comments.
Possibly this can be switched of by a compiler switch or the code has never passed
compilation. With ELDK's gcc 4.0.0 (ELDK 4.1.0) at least I run into trouble.
What about this solution:
diff --git a/include/libfdt.h b/include/libfdt.h
index 8253ccf..8050049 100644
--- a/include/libfdt.h
+++ b/include/libfdt.h
@@ -544,7 +544,7 @@ int fdt_parent_offset(const void *fdt, int nodeoffset);
* offset = fdt_node_offset_by_prop_value(fdt, -1, propname,
* propval, proplen);
* while (offset != -FDT_ERR_NOTFOUND) {
- * /* other code here */
+ * ... other code here ...
* offset = fdt_node_offset_by_prop_value(fdt, offset, propname,
* propval, proplen);
* }
@@ -629,7 +629,7 @@ int fdt_node_check_compatible(const void *fdt, int nodeoffset,
* idiom can be used:
* offset = fdt_node_offset_by_compatible(fdt, -1, compatible);
* while (offset != -FDT_ERR_NOTFOUND) {
- * /* other code here */
+ * ... other code here ...
* offset = fdt_node_offset_by_compatible(fdt, offset, compatible);
* }
*
Matthias
--
-----------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs esd electronic system design gmbh
http://www.esd-electronics.com Vahrenwalder Str. 207
phone: +49-511-37298-0, fax: -68 30165 Hannover, Germany
-----------------------------------------------------------------------
next reply other threads:[~2008-01-02 12:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-02 12:46 Matthias Fuchs [this message]
2008-01-02 13:13 ` [U-Boot-Users] /* inside comment in libfdt.h Jerry Van Baren
2008-01-02 13:49 ` Matthias Fuchs
2008-01-03 19:28 ` Jon Loeliger
2008-01-03 19:35 ` Scott Wood
2008-01-03 19:47 ` Jerry Van Baren
2008-01-03 23:41 ` David Gibson
2008-01-04 10:24 ` Matthias Fuchs
2008-01-04 12:43 ` Jerry Van Baren
2008-01-04 16:22 ` Jon Loeliger
2008-01-02 15:01 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801021347.01153.matthias.fuchs@esd-electronics.com \
--to=matthias.fuchs@esd-electronics.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox