From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Fuchs Date: Wed, 2 Jan 2008 14:49:38 +0100 Subject: [U-Boot-Users] /* inside comment in libfdt.h In-Reply-To: <477B8DE6.5060501@ge.com> References: <200801021347.01153.matthias.fuchs@esd-electronics.com> <477B8DE6.5060501@ge.com> Message-ID: <200801021449.38516.matthias.fuchs@esd-electronics.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 02 January 2008 14:13, Jerry Van Baren wrote: C++ style comments inside comments are no comments :-) I could life with //, but if people do cut'n'paste we get // in our code - and 'ubooties' know not to use C++ style comments. When the original source uses //, we should keep that in order to stay in sync with that code. If the U-Boot community will start to stone us, the solution is .... Wolfgang, do you accept the change back to //? Matthias > Yes, nested comments is something that should not be done and should be > fixed. This was inherited from the original code, although the current > version uses // for the embedded comment which avoids the issue (but > causes "no C++ comments" people to break out in rashes). > > > > Hmm, interesting, the original appears to have always used //, so it > would appear that we (u-booties) did the change to /* */. > > I'll have to look at this further. > > My inclination is to change to embedded // comments to avoid drifting > from the original due to aesthetics rather than due to necessary > functionality differences. > > The alternative would be to convince David Gibson (/jdl) to adopt the > ...other code here... change. I prefer the ... change if it matters - > if somebody blindly cuts and pastes the example code, it won't compile > until he understands and edits what he pasted. > > Thanks, > gvb > > -- ----------------------------------------------------------------------- Dipl.-Ing. Matthias Fuchs esd electronic system design gmbh http://www.esd-electronics.com Vahrenwalder Str. 207 phone: +49-511-37298-0, fax: -68 30165 Hannover, Germany -----------------------------------------------------------------------