From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] 85xx: Move include of config.h earlier.
Date: Tue, 8 Jan 2008 07:21:17 +0100 [thread overview]
Message-ID: <200801080721.17891.sr@denx.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0801080007090.8824@blarg.am.freescale.net>
Hi Kumar,
On Tuesday 08 January 2008, Kumar Gala wrote:
> Include config.h earlier in the set of #includes so as to avoid an
> incidental and duplicate definition of CFG_CACHELINE_SIZE.
Why not remove CFG_CACHELINE_SIZE (and the other CFG_CACHE_xxx stuff) from the
board config files instead? This should be defined correctly in
asm-ppc/cache.h now.
I made this cleanup for 4xx lately and probably triggered this problem for
your FSL ports. Sorry about that, but I really think these cache defines
should be removed from the board config files.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2008-01-08 6:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 6:07 [U-Boot-Users] [PATCH] 85xx: Move include of config.h earlier Kumar Gala
2008-01-08 6:21 ` Stefan Roese [this message]
2008-01-08 7:21 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801080721.17891.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox