[U-Boot-Users] [PATCH] mpc83xx: UEC: add support for Broadcom BCM5481 Gigabit PHY

[Kim Phillips <kim.phillips@freescale.com>]

On Tue, 8 Jan 2008 21:41:09 +0300
Anton Vorontsov <avorontsov@ru.mvista.com> wrote:

> On Tue, Jan 08, 2008 at 10:50:18AM -0600, Kim Phillips wrote:
> > On Tue, 25 Dec 2007 20:01:26 +0300
> > Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
> > 
> > > This patch adds basic support for Broadcom BCM5481 PHY,
> > > with the quirk needed for at least MPC8360E-RDK.
> > 
> > ?  the MPC8360E-RDK doesn't exist in the mainline tree.
> 
> Patch for the board support was sent at the same time. Though,
> I'll resend it with few improvements.

ok, yes, I'm a bit behind in my emails still :(.

I took a brief look at it; while modding, can you please:

a. reorder your Makefile entry in alpha order (per WD), and add
MAINTAINERS and MAKEALL entries.

b. move the non-board specific nand code out of the board directory and
merge with drivers/mtd/nand (this should go through Stefan Roese).

c. turn off CONFIG_OF_HAS_BD_T and CONFIG_OF_HAS_UBOOT_ENV (unless you
have a really good reason to keep them on).

d. remove references to OF_CPU, OF_SOC, OF_QE, OF_TBCLK, OF_STDOUT_PATH
and use the new libfdt glue code.

thanks in advance.

> > > Quirk comes from MPC8360E-RDK BSP source, I think author is
> > > Peter Barada <peterb@logicpd.com>, but I'm not sure.
> > 
> > solicit his signoff then?
> 
> Not an absolute necessity.
> 
ok, we'll see if Peter replies anyway.  Thanks for paying attention to
this matter.

Kim