public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] memset bug in ext2fs_read_file()
Date: Wed, 09 Jan 2008 10:15:21 +0100	[thread overview]
Message-ID: <20080109091521.98FC06F0010@nyx.denx.de> (raw)
In-Reply-To: Your message of "Wed, 19 Dec 2007 22:34:25 PST." <fkd2di$pdl$1@ger.gmane.org>

Dear Mike,

in message <fkd2di$pdl$1@ger.gmane.org> you wrote:
> 
> The ext2fs_read_file() function in fs/ext2/ext2fs.c contains the 
> following line:
> 
>   439                         memset (buf, blocksize - skipfirst, 0);
> 
> This is incorrect as the prototype of the function has the fill value as 
> the 2nd parameter and the number of bytes as the 3rd:
> 
> void *memset(void *b, int c, size_t n);
> 
> I don't have any test code that is affected by this bug. I noticed it 
> when I was investigating a different problem (with OpenMoko).

Thanks, applied.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Probably the best operating system in the world  is  the  [operating
system] made for the PDP-11 by Bell Laboratories."
                                           - Ted Nelson, October 1977

  reply	other threads:[~2008-01-09  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-20  6:34 [U-Boot-Users] memset bug in ext2fs_read_file() Mike Montour
2008-01-09  9:15 ` Wolfgang Denk [this message]
2008-01-10 21:27   ` Reinhard Arlt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080109091521.98FC06F0010@nyx.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox