public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] IXP: add dynamic microcode addr
Date: Wed, 9 Jan 2008 18:40:53 +0100	[thread overview]
Message-ID: <20080109174053.GE23358@game.jcrosoft.org> (raw)
In-Reply-To: <200801091423.43071.sr@denx.de>

On 14:23 Wed 09 Jan     , Stefan Roese wrote:
> On Wednesday 09 January 2008, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > allow to load the microde from flash or ram by download it through
> > the serial or other.
> >
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> >
> > diff --git a/cpu/ixp/npe/IxNpeDlImageMgr.c b/cpu/ixp/npe/IxNpeDlImageMgr.c
> > index c0e7349..1c47661 100644
> > --- a/cpu/ixp/npe/IxNpeDlImageMgr.c
> > +++ b/cpu/ixp/npe/IxNpeDlImageMgr.c
> > @@ -140,6 +140,13 @@ static UINT32 *IxNpeMicroCodeImageLibrary = (UINT32
> > *)CONFIG_IXP4XX_NPE_EXT_UCOD static UINT32 *IxNpeMicroCodeImageLibrary =
> > (UINT32 *)IxNpeMicrocode_array; #endif
> >
> > +static UNIT32* getIxNpeMicroCodeImageLibrary()
> > +{
> > +	if ((s = getenv("microcodeaddr")) != NULL) {
> > +		load_addr = simple_strtoul(s, NULL, 16);
> > +	}
> > +	else return IxNpeMicroCodeImageLibrary;
> 
> 	if ((s = getenv("microcodeaddr")) != NULL)
> 		load_addr = simple_strtoul(s, NULL, 16);
> 	else
> 		return IxNpeMicroCodeImageLibrary;
> 
> please.
Done.
> 
> I'm not so sure about the naming of the env variable too. How 
> about "npe_ucode"?

Why not

Best regards,
J.

  reply	other threads:[~2008-01-09 17:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 12:30 [U-Boot-Users] [PATCH] PATCH: load ixp42x NPE firmware from separate flash block, remove dead code Jean-Christophe PLAGNIOL-VILLARD
2008-01-09 12:34 ` [U-Boot-Users] [PATCH] IXP: add dynamic microcode addr Jean-Christophe PLAGNIOL-VILLARD
2008-01-09 13:23   ` Stefan Roese
2008-01-09 17:40     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-01-09 17:49     ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-09 17:56     ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-09 18:36       ` Stefan Roese
2008-01-10 22:05 ` [U-Boot-Users] [PATCH] PATCH: load ixp42x NPE firmware from separate flash block, remove dead code Michael Schwingen
2008-01-10 23:32   ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080109174053.GE23358@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox