public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx board header files
Date: Thu, 10 Jan 2008 21:30:14 -0600	[thread overview]
Message-ID: <20080110213014.fea18e3a.kim.phillips@freescale.com> (raw)
In-Reply-To: <11998953923671-git-send-email-timur@freescale.com>

On Wed,  9 Jan 2008 10:16:32 -0600
Timur Tabi <timur@freescale.com> wrote:

> Remove the "#undef DEBUG" line from all Freescale 83xx board header files.
> The inclusion of this line makes it impossible to enable debug code in
> other source files, because "#define DEBUG" typically needs to be defined
> before any header files are included.
> 
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
>  include/configs/MPC8323ERDB.h |    2 --
>  include/configs/MPC832XEMDS.h |    2 --
>  include/configs/MPC8349EMDS.h |    2 --
>  include/configs/MPC8360EMDS.h |    2 --
>  include/configs/MPC837XEMDS.h |    2 --
>  5 files changed, 0 insertions(+), 10 deletions(-)

hmm..what about the rest of the boards that do this?:

include/configs/AP1000.h:#undef DEBUG
include/configs/BAB7xx.h:#undef  DEBUG
include/configs/EB+MCF-EV123.h:#undef DEBUG
include/configs/ELPPC.h:#undef  DEBUG
include/configs/IPHASE4539.h:#undef DEBUG                               /* General debug */
include/configs/M5235EVB.h:#undef DEBUG
include/configs/M5271EVB.h:#undef DEBUG
include/configs/M5329EVB.h:#undef DEBUG
include/configs/M54455EVB.h:#undef DEBUG
include/configs/MPC8360ERDK.h:#undef DEBUG
include/configs/MPC8540EVAL.h:#undef DEBUG
include/configs/MVBLUE.h:#undef DEBUG
include/configs/QS823.h:#undef DEBUG                            /* debug output code */
include/configs/QS850.h:#undef DEBUG                            /* debug output code */
include/configs/QS860T.h:#undef DEBUG                           /* debug output code */
include/configs/Rattler.h:#undef DEBUG
include/configs/ads5121.h:#undef DEBUG
include/configs/assabet.h:#undef DEBUG
include/configs/ep8248.h:#undef DEBUG
include/configs/ep82xxm.h:#undef DEBUG
include/configs/gw8260.h:#undef DEBUG                  /* General debug */
include/configs/mpc7448hpc2.h:#undef DEBUG
include/configs/ms7722se.h:#undef DEBUG
include/configs/ms7750se.h:#undef DEBUG
include/configs/sacsng.h:#undef DEBUG                 /* General debug */
include/configs/sbc8260.h:#undef DEBUG                /* General debug */
include/configs/sbc8349.h:#undef DEBUG

Kim

  reply	other threads:[~2008-01-11  3:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 16:16 [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx board header files Timur Tabi
2008-01-11  3:30 ` Kim Phillips [this message]
2008-01-11  3:34   ` [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx boardheader files Liu Dave
2008-01-11 15:05     ` Timur Tabi
2008-01-12  2:06       ` Liu Dave
2008-01-11 19:32     ` Wolfgang Denk
2008-01-12  2:16       ` [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xxboardheader files Liu Dave
2008-01-11 15:06   ` [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx board header files Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080110213014.fea18e3a.kim.phillips@freescale.com \
    --to=kim.phillips@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox