public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix "i2c sdram" command for DDR2 DIMMs
Date: Fri, 11 Jan 2008 07:44:03 +0100	[thread overview]
Message-ID: <200801110744.04262.sr@denx.de> (raw)
In-Reply-To: <4786E13B.3030105@acm.org>

On Friday 11 January 2008, Larry Johnson wrote:
> Many of the SPD bytes for DDR2 SDRAM are not interpreted correctly by the
> "i2c sdram" command.  This patch provides correct alternative
> interpretations when DDR2 memory is detected.
>
> Signed-off-by: Larry Johnson <lrj@acm.org>
> ---
> Hi Wolfgang and Stefan and group,
>
> In this patch, I have fixed the DDR2 output for the SPD bytes currently
> displayed by the "i2c sdram".  I have not added any display for the
> additional bytes defined in DDR2; I may do that later when I have time.
>
> I don't have any way of testing the patched code for non-DDR2 memory, but
> if I force the code to treat the DDR2 memory type as "unknown", I get the
> same values as before the patch.

I'll give it a try on a DDR system in a short while.

> Stefan, the added size of this causes a section overlap on the Luan board,
> and makes the existing overlap on the Ocotea board worse.

This should not be a real problem with the bss NOLOAD patch applied:

[PATCH] Fix linker scripts: add NOLOAD atribute to .bss/.sbss sections

Wolfgang: What's the status with this patch?

> If memory size is critical, I could redo this patch using conditional
> compilation for different memory types, though I believe this would add
> complexity and reduce flexibility.  If you would prefer this, please let
> me know.

Let's wait on the results with the NOLOAD patch first.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-01-11  6:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-11  3:23 [U-Boot-Users] [PATCH] Fix "i2c sdram" command for DDR2 DIMMs Larry Johnson
2008-01-11  6:44 ` Stefan Roese [this message]
2008-01-11 13:35 ` Jerry Van Baren
2008-01-11 17:02   ` Jon Loeliger
2008-01-11 17:20     ` Jerry Van Baren
2008-01-11 21:25   ` Lawrence R. Johnson
2008-01-11 21:46     ` Jerry Van Baren
2008-01-12 17:29 ` gvb.uboot
2008-01-12 20:02 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801110744.04262.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox