From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx boardheader files
Date: Fri, 11 Jan 2008 20:32:28 +0100 [thread overview]
Message-ID: <20080111193228.2D29124656@gemini.denx.de> (raw)
In-Reply-To: Your message of "Fri, 11 Jan 2008 11:34:44 +0800." <58A20A281BAF1047B4EAE68DE5C0BDC2C0E189@zch01exm21.fsl.freescale.net>
In message <58A20A281BAF1047B4EAE68DE5C0BDC2C0E189@zch01exm21.fsl.freescale.net> you wrote:
> I suggest keep the debug option - #undef DEBUG.
DEBUG is not defined by default, so this statement is redundant at
best, harmful in some cases (when you try to enable debug globally).
> Sometimes, if we need debug, it is easy to open the debug mode
> with the switch.
But you don't need the #undef DEBUG for that.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Don't try to outweird me, three-eyes. I get stranger things than you
free with my breakfast cereal."
- Zaphod Beeblebrox in "Hitchhiker's Guide to the Galaxy"
next prev parent reply other threads:[~2008-01-11 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 16:16 [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx board header files Timur Tabi
2008-01-11 3:30 ` Kim Phillips
2008-01-11 3:34 ` [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx boardheader files Liu Dave
2008-01-11 15:05 ` Timur Tabi
2008-01-12 2:06 ` Liu Dave
2008-01-11 19:32 ` Wolfgang Denk [this message]
2008-01-12 2:16 ` [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xxboardheader files Liu Dave
2008-01-11 15:06 ` [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx board header files Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080111193228.2D29124656@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox