From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 4/5]: add AcTux-3 board support
Date: Sat, 12 Jan 2008 19:53:08 +0100 [thread overview]
Message-ID: <20080112185308.397F724755@gemini.denx.de> (raw)
In-Reply-To: Your message of "Sat, 12 Jan 2008 15:03:17 +0100." <20080112140317.GE6978@discworld.dascon.de>
In message <20080112140317.GE6978@discworld.dascon.de> you wrote:
> Signed-off-by: Michael Schwingen <michael@schwingen.org>
There are coding style issyes: C++ comments, indentation not by TAB,
much too long lines, etc.
Indentation in general looks pretty sloppy, especially in the board
config files.
Please clean up and resubmit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Extended Epstein-Heisenberg Principle: In an R & D orbit, only 2 of
the existing 3 parameters can be defined simultaneously. The parame-
ters are: task, time and resources ($).
next prev parent reply other threads:[~2008-01-12 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 14:03 [U-Boot-Users] [PATCH 4/5]: add AcTux-3 board support Michael Schwingen
2008-01-12 18:53 ` Wolfgang Denk [this message]
2008-01-13 12:55 ` [U-Boot-Users] resend " Michael Schwingen
2008-01-14 8:05 ` [U-Boot-Users] resend #2 " Michael Schwingen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080112185308.397F724755@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox