From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files
Date: Tue, 15 Jan 2008 18:43:51 -0600 [thread overview]
Message-ID: <20080115184351.0ffb9196.kim.phillips@freescale.com> (raw)
In-Reply-To: <12004385814106-git-send-email-timur@freescale.com>
On Tue, 15 Jan 2008 17:09:41 -0600
Timur Tabi <timur@freescale.com> wrote:
> Remove the "#undef DEBUG" line from all Freescale 83xx board header files.
> The inclusion of this line makes it impossible to enable debug code in
> other source files, because "#define DEBUG" typically needs to be defined
> before any header files are included.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
>
> Added MPC8360ERDK.h.
>
> include/configs/MPC8323ERDB.h | 2 --
> include/configs/MPC832XEMDS.h | 2 --
> include/configs/MPC8349EMDS.h | 2 --
> include/configs/MPC8360EMDS.h | 2 --
> include/configs/MPC8360ERDK.h | 2 --
> include/configs/MPC837XEMDS.h | 2 --
> 6 files changed, 0 insertions(+), 12 deletions(-)
? Am I missing something? mpc83xx files aren't special in this area.
it appears to be a problem for a lot of boards:
include/configs/ads5121.h:#undef DEBUG
include/configs/AP1000.h:#undef DEBUG
include/configs/assabet.h:#undef DEBUG
include/configs/BAB7xx.h:#undef DEBUG
include/configs/EB+MCF-EV123.h:#undef DEBUG
include/configs/ELPPC.h:#undef DEBUG
include/configs/ep8248.h:#undef DEBUG
include/configs/ep82xxm.h:#undef DEBUG
include/configs/gcplus.h:#undef DEBUG
include/configs/gw8260.h:#undef DEBUG /* General debug */
include/configs/IPHASE4539.h:#undef DEBUG /* General debug */
include/configs/M5235EVB.h:#undef DEBUG
include/configs/M5271EVB.h:#undef DEBUG
include/configs/M5329EVB.h:#undef DEBUG
include/configs/M54455EVB.h:#undef DEBUG
include/configs/mgcoge.h:#undef DEBUG
include/configs/mpc7448hpc2.h:#undef DEBUG
include/configs/MPC8323ERDB.h:#undef DEBUG
include/configs/MPC832XEMDS.h:#undef DEBUG
include/configs/MPC8349EMDS.h:#undef DEBUG
include/configs/MPC8360EMDS.h:#undef DEBUG
include/configs/MPC8360ERDK.h:#undef DEBUG
include/configs/MPC837XEMDS.h:#undef DEBUG
include/configs/MPC8540EVAL.h:#undef DEBUG
include/configs/ms7722se.h:#undef DEBUG
include/configs/ms7750se.h:#undef DEBUG
include/configs/MVBLUE.h:#undef DEBUG
include/configs/ppmc7xx.h:#undef DEBUG
include/configs/QS823.h:#undef DEBUG /* debug output code */
include/configs/QS850.h:#undef DEBUG /* debug output code */
include/configs/QS860T.h:#undef DEBUG /* debug output code */
include/configs/Rattler.h:#undef DEBUG
include/configs/sacsng.h:#undef DEBUG /* General debug */
include/configs/sbc8260.h:#undef DEBUG /* General debug */
include/configs/sbc8349.h:#undef DEBUG
Kim
next prev parent reply other threads:[~2008-01-16 0:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 23:09 [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files Timur Tabi
2008-01-16 0:43 ` Kim Phillips [this message]
2008-01-16 15:00 ` Timur Tabi
2008-01-16 16:30 ` Kim Phillips
2008-01-16 1:57 ` [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx boardheader files Liu Dave
2008-02-11 23:45 ` [U-Boot-Users] [PATCH v2] Remove #undef DEBUG from MPC83xx board header files Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115184351.0ffb9196.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox