public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] resend #4: [PATCH 4/5]: add AcTux-3 board	support
Date: Wed, 16 Jan 2008 02:41:37 +0100	[thread overview]
Message-ID: <20080116014137.GB31365@game.jcrosoft.org> (raw)
In-Reply-To: <20080115191249.GE27903@discworld.dascon.de>

On 20:12 Tue 15 Jan     , Michael Schwingen wrote:
> 
> Signed-off-by: Michael Schwingen <michael@schwingen.org>
> 
> diff --git a/board/actux3/Makefile b/board/actux3/Makefile
> new file mode 100644
> index 0000000..f6168c3
> --- /dev/null
> +++ b/board/actux3/Makefile
> @@ -0,0 +1,50 @@
> +#
> +int dram_init (void)
> +{
> +	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
> +	gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
> +
> +	return (0);
> +}
> +
> +void reset_phy (void)
> +{
> +	int i;
> +
> +	/* initialize the PHY */
> +	miiphy_reset ("NPE0", CONFIG_PHY_ADDR);
> +
> +	/* all LED outputs = Link/Act */
> +	miiphy_write ("NPE0", CONFIG_PHY_ADDR, 0x16, 0x0AAA);
> +
> +	/* set all ethernet switch ports to forwarding state */
> +	for (i = 1; i <= 5; i++)
> +		miiphy_write ("NPE0", CONFIG_PHY_ADDR + 8 + i, 0x04, 0x03);
> +
> +}

Could you specify cleary in each baord file on which do you work and
please  be more explicit about his constants, rather than using magic
numbers.

if possible use hexa value.

Best Regards,
J.

  reply	other threads:[~2008-01-16  1:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-15 19:12 [U-Boot-Users] resend #4: [PATCH 4/5]: add AcTux-3 board support Michael Schwingen
2008-01-16  1:41 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-01-16  8:16   ` Michael Schwingen
2008-01-16 10:21     ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-16 17:30       ` Michael Schwingen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080116014137.GB31365@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox