From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
Date: Wed, 16 Jan 2008 12:31:15 +0100
Subject: [U-Boot-Users] [PATCH V2] net: add 'ethrotate' environment
	variable
In-Reply-To: <47882ABC.7030304@gmail.com>
References: <20080109215130.E58C7242E7@gemini.denx.de>
	<200801101003.55140.matthias.fuchs@esd-electronics.com>
	<47882ABC.7030304@gmail.com>
Message-ID: <200801161231.16092.matthias.fuchs@esd-electronics.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Ben,

On Saturday 12 January 2008 03:49, Ben Warren wrote:
> I'm a little curious about what it is you're trying to do.  If you want 
> to prevent Ethernet devices from ever rotating, this doesn't work.  For 
> example, if you set 'ethact' to an interface that isn't connected, 
> eth_init() will rotate the interfaces until it reaches a valid link or 
> the end of the chain, never reaching your change.  If you really want to 
> prevent rotation, I'd move your logic into the 'eth_try_another()' 
> function itself, returning quickly if "ethrotate=no".
> 
> regards,
> Ben
> 
I will post a fixing patch in a minute.

Matthias