From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
Date: Wed, 16 Jan 2008 12:52:11 +0100
Subject: [U-Boot-Users] [PATCH V2] ppc4xx: Add DU440 board support
In-Reply-To: <200801161219.08916.sr@denx.de>
References: <20080113220820.B3161247C1@gemini.denx.de>
	<200801161147.20583.matthias.fuchs@esd-electronics.com>
	<200801161219.08916.sr@denx.de>
Message-ID: <200801161252.12199.matthias.fuchs@esd-electronics.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

My dear old Mr. 'mir-doch-egal',

I don't dare to remember your old times at your previous company ...
I think it would be funny for other's to post some of Stefan's code here
from his pre-Denx era. The comments would explose the list's size limit :-)

Yes, I will fix the issue below. Just a minute.

BTW, what about removing some lines when quoting such a huge patch.

On Wednesday 16 January 2008 12:19, Stefan Roese wrote:
> On Wednesday 16 January 2008, Matthias Fuchs wrote:
> > Signed-off-by: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
> 
> Still some comments below.
> 
> > +	if(dvi_init())
> 
> Space after "(" please.
> 
> > +		du440_post_errors++;

> > +int last_stage_init(void)
> > +{
> > +	int e, i;
> 
> Empty newline after variable declaration.
> 
> > +	/* everyting is ok: turn on POST-LED */

> > +	int U;
> 
> Upper case variables? Please use something else here.
> 
> > +	oldbus = I2C_GET_BUS();

> > +{
> > +	int U;
> 
> Again.
> 

> > + */
> 
> Yes, please don't forget about this. Sounds interesting. :)
> 
> > +int do_time(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
You are welcome to do this before me.

Matthias