From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Thu, 17 Jan 2008 08:25:31 +0100
Subject: [U-Boot-Users] [PATCH V3] ppc4xx: Add DU440 board support
In-Reply-To: <200801161259.37591.matthias.fuchs@esd-electronics.com>
References: <20080113220820.B3161247C1@gemini.denx.de>
	<200801161219.08916.sr@denx.de>
	<200801161259.37591.matthias.fuchs@esd-electronics.com>
Message-ID: <200801170825.31417.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday 16 January 2008, Matthias Fuchs wrote:
> Signed-off-by: Matthias Fuchs <matthias.fuchs@esd-electronics.com>

Please find some comments below.

> +++ b/board/esd/du440/du440.c
> @@ -0,0 +1,1018 @@
> +/*

<snip>

> +/*
> + * pci_pre_init
> + *
> + * This routine is called just prior to registering the hose and gives
> + * the board the opportunity to check things. Returning a value of zero
> + * indicates that things are bad & PCI initialization should be aborted.
> + *
> + * Different boards may wish to customize the pci controller structure
> + * (add regions, override default access routines, etc) or perform
> + * certain pre-initialization actions.
> + */
> +#if defined(CONFIG_PCI) && defined(CFG_PCI_PRE_INIT)

CFG_PCI_PRE_INIT was removed some time ago (with your help btw).
Please remove this #ifdef.

Please fix and resubmit.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================