public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [patch u-boot git 1/3] add missing ARM boards to MAKEALL
@ 2008-01-18 20:45 David Brownell
  2008-01-18 20:50 ` [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options David Brownell
  2008-03-30 14:37 ` [U-Boot-Users] [patch u-boot git 1/3] add missing ARM boards to MAKEALL Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 2 replies; 7+ messages in thread
From: David Brownell @ 2008-01-18 20:45 UTC (permalink / raw)
  To: u-boot

Add some missing ARM boards to MAKEALL.  These build correctly,
unlike several of the boards already listed.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

--- u-boot.orig/MAKEALL	2008-01-13 10:42:55.000000000 -0800
+++ u-boot/MAKEALL	2008-01-13 10:42:59.000000000 -0800
@@ -455,6 +455,8 @@ LIST_ARM9="			\
 	cp926ejs		\
 	cp946es			\
 	cp966			\
+	csb637			\
+	kb9202			\
 	lpd7a400		\
 	mp2usb			\
 	mx1ads			\
@@ -463,6 +465,7 @@ LIST_ARM9="			\
 	omap1510inn		\
 	omap1610h2		\
 	omap1610inn		\
+	omap5912osk		\
 	omap730p2		\
 	sbc2410x		\
 	scb9328			\

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options
@ 2008-01-18 20:50 ` David Brownell
  2008-01-21 23:26   ` Ulf Samuelsson
  2008-03-30 14:49   ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 2 replies; 7+ messages in thread
From: David Brownell @ 2008-01-18 20:50 UTC (permalink / raw)
  To: u-boot

Update some ARM9 builds to pass the exact CPU to GCC, when the compiler
supports that specification.  This stops pessimizing codegen, and removes
voluminous warnings about (no) interworking support from EABI compilers.
(Like CodeSourcery's ARM 2007q3 release.)

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

--- u-boot.orig/cpu/arm920t/config.mk	2008-01-13 10:42:55.000000000 -0800
+++ u-boot/cpu/arm920t/config.mk	2008-01-13 11:05:02.000000000 -0800
@@ -24,11 +24,11 @@
 PLATFORM_RELFLAGS += -fno-strict-aliasing  -fno-common -ffixed-r8 \
 	-msoft-float
 
-PLATFORM_CPPFLAGS += -march=armv4
 # =========================================================================
 #
 # Supply options according to compiler version
 #
 # =========================================================================
+PLATFORM_CPPFLAGS +=$(call cc-option,-mcpu=arm920t,-march=armv4)
 PLATFORM_CPPFLAGS +=$(call cc-option,-mapcs-32,-mabi=apcs-gnu)
 PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,))
--- u-boot.orig/cpu/arm926ejs/config.mk	2008-01-13 10:42:55.000000000 -0800
+++ u-boot/cpu/arm926ejs/config.mk	2008-01-13 11:04:56.000000000 -0800
@@ -24,11 +24,11 @@
 PLATFORM_RELFLAGS += -fno-strict-aliasing  -fno-common -ffixed-r8 \
 	-msoft-float
 
-PLATFORM_CPPFLAGS += -march=armv4
 # =========================================================================
 #
 # Supply options according to compiler version
 #
 # =========================================================================
+PLATFORM_CPPFLAGS +=$(call cc-option,-mcpu=arm926ej-s,-march=armv4)
 PLATFORM_CPPFLAGS +=$(call cc-option,-mapcs-32,-mabi=apcs-gnu)
 PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,))

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options
  2008-01-18 20:50 ` [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options David Brownell
@ 2008-01-21 23:26   ` Ulf Samuelsson
  2008-01-22  0:24     ` [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compileroptions Woodruff, Richard
  2008-01-22  0:53     ` [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options David Brownell
  2008-03-30 14:49   ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 2 replies; 7+ messages in thread
From: Ulf Samuelsson @ 2008-01-21 23:26 UTC (permalink / raw)
  To: u-boot

> Update some ARM9 builds to pass the exact CPU to GCC, when the compiler
> supports that specification.  This stops pessimizing codegen, and removes
> voluminous warnings about (no) interworking support from EABI compilers.
> (Like CodeSourcery's ARM 2007q3 release.)
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> 
> --- u-boot.orig/cpu/arm920t/config.mk 2008-01-13 10:42:55.000000000 -0800
> +++ u-boot/cpu/arm920t/config.mk 2008-01-13 11:05:02.000000000 -0800
> @@ -24,11 +24,11 @@
> PLATFORM_RELFLAGS += -fno-strict-aliasing  -fno-common -ffixed-r8 \
>  -msoft-float

Why not remove the "-msoft-float" as well.
U-Boot does not use soft float and why then the requirement to 
use a compiler which supports soft-float???

> 
> -PLATFORM_CPPFLAGS += -march=armv4
> # =========================================================================
> #
> # Supply options according to compiler version
> #
> # =========================================================================
> +PLATFORM_CPPFLAGS +=$(call cc-option,-mcpu=arm920t,-march=armv4)
> PLATFORM_CPPFLAGS +=$(call cc-option,-mapcs-32,-mabi=apcs-gnu)
> PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,))
> --- u-boot.orig/cpu/arm926ejs/config.mk 2008-01-13 10:42:55.000000000 -0800
> +++ u-boot/cpu/arm926ejs/config.mk 2008-01-13 11:04:56.000000000 -0800
> @@ -24,11 +24,11 @@
> PLATFORM_RELFLAGS += -fno-strict-aliasing  -fno-common -ffixed-r8 \
>  -msoft-float
> 
> -PLATFORM_CPPFLAGS += -march=armv4
> # =========================================================================
> #
> # Supply options according to compiler version
> #
> # =========================================================================
> +PLATFORM_CPPFLAGS +=$(call cc-option,-mcpu=arm926ej-s,-march=armv4)
> PLATFORM_CPPFLAGS +=$(call cc-option,-mapcs-32,-mabi=apcs-gnu)
> PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,))
> 


Is this correct?
ARM926EJ-S is ARMV5 architecture, not ARMV4.


Best Regards
Ulf Samuelsson 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compileroptions
  2008-01-21 23:26   ` Ulf Samuelsson
@ 2008-01-22  0:24     ` Woodruff, Richard
  2008-01-22  0:53     ` [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options David Brownell
  1 sibling, 0 replies; 7+ messages in thread
From: Woodruff, Richard @ 2008-01-22  0:24 UTC (permalink / raw)
  To: u-boot


> Is this correct?
> ARM926EJ-S is ARMV5 architecture, not ARMV4.

Yes, 926EJ-S is ARMv5.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options
  2008-01-21 23:26   ` Ulf Samuelsson
  2008-01-22  0:24     ` [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compileroptions Woodruff, Richard
@ 2008-01-22  0:53     ` David Brownell
  1 sibling, 0 replies; 7+ messages in thread
From: David Brownell @ 2008-01-22  0:53 UTC (permalink / raw)
  To: u-boot

On Monday 21 January 2008, Ulf Samuelsson wrote:
> > --- u-boot.orig/cpu/arm920t/config.mk 2008-01-13 10:42:55.000000000 -0800
> > +++ u-boot/cpu/arm920t/config.mk 2008-01-13 11:05:02.000000000 -0800
> > @@ -24,11 +24,11 @@
> > PLATFORM_RELFLAGS += -fno-strict-aliasing  -fno-common -ffixed-r8 \
> >  -msoft-float
> 
> Why not remove the "-msoft-float" as well.
> U-Boot does not use soft float

It shouldn't use floating point of any flavor, in fact.
But when some accident makes it try to do so, "soft" is
the only potentially safe approach.


> and why then the requirement to  
> use a compiler which supports soft-float???

That change would be orthogonal.  And potentially troublesome; I
have seen build breakage in U-Boot that was fixed by disabling
even the accidental use of hard-float code.


> > --- u-boot.orig/cpu/arm926ejs/config.mk 2008-01-13 10:42:55.000000000 -0800
> > +++ u-boot/cpu/arm926ejs/config.mk 2008-01-13 11:04:56.000000000 -0800
> > @@ -24,11 +24,11 @@
> > PLATFORM_RELFLAGS += -fno-strict-aliasing  -fno-common -ffixed-r8 \
> >  -msoft-float
> > 
> > -PLATFORM_CPPFLAGS += -march=armv4
> > # =========================================================================
> > #
> > # Supply options according to compiler version
> > #
> > # =========================================================================
> > +PLATFORM_CPPFLAGS +=$(call cc-option,-mcpu=arm926ej-s,-march=armv4)
> > PLATFORM_CPPFLAGS +=$(call cc-option,-mapcs-32,-mabi=apcs-gnu)
> > PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,))
> > 
> 
> 
> Is this correct?

Sure.  If that fallback is used, it's just a fallback to sub-optimal
code generation.  No CLZ, probably the wrong guesses about pipelines,
and so on.  But probably still safe on ancient compilers.


> ARM926EJ-S is ARMV5 architecture, not ARMV4.

In fact it's ARMv5tej ... an ARMv4 superset.

The specific compiler warnings that annoyed me would vanish by passing
an "armv4t" option ... that'd be OK on most CPUs that U-Boot supports.
But I don't see much reason not to specify the actual CPU, and thus to
get the benefit of smarter scheduling on newer compilers.

- Dave

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot-Users] [patch u-boot git 1/3] add missing ARM boards to MAKEALL
  2008-01-18 20:45 [U-Boot-Users] [patch u-boot git 1/3] add missing ARM boards to MAKEALL David Brownell
  2008-01-18 20:50 ` [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options David Brownell
@ 2008-03-30 14:37 ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 0 replies; 7+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2008-03-30 14:37 UTC (permalink / raw)
  To: u-boot

On 12:45 Fri 18 Jan     , David Brownell wrote:
> Add some missing ARM boards to MAKEALL.  These build correctly,
> unlike several of the boards already listed.
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Applied

Best Regards,
J.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options
  2008-01-18 20:50 ` [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options David Brownell
  2008-01-21 23:26   ` Ulf Samuelsson
@ 2008-03-30 14:49   ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 0 replies; 7+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2008-03-30 14:49 UTC (permalink / raw)
  To: u-boot

On 12:50 Fri 18 Jan     , David Brownell wrote:
> Update some ARM9 builds to pass the exact CPU to GCC, when the compiler
> supports that specification.  This stops pessimizing codegen, and removes
> voluminous warnings about (no) interworking support from EABI compilers.
> (Like CodeSourcery's ARM 2007q3 release.)
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> 
NOK

I've the following warning when I'm using it

nfs.c:1: warning: switch -mcpu=arm926ej-s conflicts with -march= switch
sntp.c:1: warning: switch -mcpu=arm926ej-s conflicts with -march= switch
part.c:0: warning: switch -mcpu=arm926ej-s conflicts with -march= switch

My toolchains

Using built-in specs.
Target: arm-elf
Configured with: ../configure --prefix=/opt/arm --target=arm-elf --enable-interwork --enable-multilib --enable-languages=c,c++ --with-newlib --with-headers=/opt/arm/src/newlib-1.14.0/newlib/libc/include
Thread model: single
gcc version 4.1.1

Best Regards,
J.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2008-03-30 14:49 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-18 20:45 [U-Boot-Users] [patch u-boot git 1/3] add missing ARM boards to MAKEALL David Brownell
2008-01-18 20:50 ` [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options David Brownell
2008-01-21 23:26   ` Ulf Samuelsson
2008-01-22  0:24     ` [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compileroptions Woodruff, Richard
2008-01-22  0:53     ` [U-Boot-Users] [patch u-boot git 2/3] better ARM9 compiler options David Brownell
2008-03-30 14:49   ` Jean-Christophe PLAGNIOL-VILLARD
2008-03-30 14:37 ` [U-Boot-Users] [patch u-boot git 1/3] add missing ARM boards to MAKEALL Jean-Christophe PLAGNIOL-VILLARD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox