public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Use `ln -sf` rather than `rm -f && ln -s`
Date: Mon, 28 Jan 2008 06:38:58 -0500	[thread overview]
Message-ID: <200801280638.59012.vapier@gentoo.org> (raw)
In-Reply-To: <1201520254-25593-1-git-send-email-vapier@gentoo.org>

odd ... git-send-email ate the explanatory text ...
---
The -f option to `ln` should give the same behavior as the -f option to the
`rm` command.  It is better to do this in one shot so as to avoid race
conditions when building in parallel.  I build on a quad G5 and without this
change, it isn't uncommon for the build to fail when using -j8 due to this
small window where the files don't actually exist.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 tools/Makefile |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/tools/Makefile b/tools/Makefile
index af0de47..22d9dae 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -203,19 +203,16 @@ else
 endif
 
 $(obj)environment.c:
-		@rm -f $(obj)environment.c
-		ln -s $(src)../common/environment.c $(obj)environment.c
+		ln -s -f $(src)../common/environment.c $(obj)environment.c
 
 $(obj)environment.o:	$(obj)environment.c
 		$(CC) -g $(HOST_ENVIRO_CFLAGS) $(CPPFLAGS) -c -o $@ $<
 
 $(obj)crc32.c:
-		@rm -f $(obj)crc32.c
-		ln -s $(src)../lib_generic/crc32.c $(obj)crc32.c
+		ln -s -f $(src)../lib_generic/crc32.c $(obj)crc32.c
 
 $(obj)sha1.c:
-		@rm -f $(obj)sha1.c
-		ln -s $(src)../lib_generic/sha1.c $(obj)sha1.c
+		ln -s -f $(src)../lib_generic/sha1.c $(obj)sha1.c
 
 $(LOGO_H):	$(obj)bmp_logo $(LOGO_BMP)
 		$(obj)./bmp_logo $(LOGO_BMP) >$@
-- 
1.5.3.8

  reply	other threads:[~2008-01-28 11:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28 11:37 [U-Boot-Users] [PATCH] Use `ln -sf` rather than `rm -f && ln -s` Mike Frysinger
2008-01-28 11:38 ` Mike Frysinger [this message]
2008-01-28 20:56   ` Wolfgang Denk
2008-01-28 21:16     ` Mike Frysinger
2008-01-28 21:41       ` J. William Campbell
2008-01-28 23:11   ` Johannes Stezenbach
2008-01-29  0:27     ` Mike Frysinger
2008-02-14  0:18     ` Wolfgang Denk
2008-01-28 20:53 ` Wolfgang Denk
2008-01-28 20:57   ` Mike Frysinger
2008-04-14 19:50     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801280638.59012.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox