From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c
Date: Mon, 28 Jan 2008 22:27:05 -0500 [thread overview]
Message-ID: <200801282227.06426.vapier@gentoo.org> (raw)
The cmd_reset member of the flash info struct is not initialized until the
specific cmdset function is called. This normally happens by:
flash_get_size -> flash_detect_cfi -> cmdset_*_init
That means we cannot use cmd_reset inside of the cfi detection functions.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index eb509f5..eb3f517 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -1538,7 +1538,7 @@
{
int cfi_offset;
- flash_write_cmd (info, 0, 0, info->cmd_reset);
+ flash_write_cmd (info, 0, 0, FLASH_CMD_RESET);
for (cfi_offset=0;
cfi_offset < sizeof(flash_offset_cfi) / sizeof(uint);
cfi_offset++) {
next reply other threads:[~2008-01-29 3:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 3:27 Mike Frysinger [this message]
2008-01-29 6:15 ` [U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c Stefan Roese
2008-01-29 13:05 ` Mike Frysinger
2008-01-29 13:13 ` Stefan Roese
2008-02-03 15:56 ` Michael Schwingen
2008-02-04 10:13 ` Stefan Roese
2008-02-04 15:48 ` Michael Schwingen
2008-02-04 16:05 ` Stefan Roese
2008-02-05 9:45 ` Michael Schwingen
2008-02-05 9:52 ` Stefan Roese
2008-02-18 22:16 ` Michael Schwingen
2008-02-20 9:18 ` Stefan Roese
2008-02-20 9:50 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801282227.06426.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox