[U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c

[Mike Frysinger <vapier@gentoo.org>]

On Tuesday 29 January 2008, Stefan Roese wrote:
> On Tuesday 29 January 2008, Mike Frysinger wrote:
> > The cmd_reset member of the flash info struct is not initialized until
> > the specific cmdset function is called.  This normally happens by:
> >  flash_get_size -> flash_detect_cfi -> cmdset_*_init
> > That means we cannot use cmd_reset inside of the cfi detection functions.
>
> Right. But your version now uses the Intel reset command (0xff)
> unconditionally. AMD/Spansion style flash chips need AMD_CMD_RESET (0xf0)
> instead. Any idea how we should handle this?

i saw that, but there's a define already to account for this i think: 
CFG_FLASH_CFI_AMD_RESET ... or did i miss the purpose of this ?

the other option is to just not issue a reset ... when i looked at the kernel, 
it didnt seem to issue a reset in the cfi detection case
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080129/8a3f936f/attachment.pgp