From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [Patch] Disable icache before call the first line of kernel in do_bootelf().
Date: Fri, 1 Feb 2008 10:42:19 -0500 [thread overview]
Message-ID: <200802011042.20282.vapier@gentoo.org> (raw)
In-Reply-To: <20080130153604.GA9497@sig21.net>
On Wednesday 30 January 2008, Johannes Stezenbach wrote:
> On Tue, Jan 29, 2008 at 07:12:10PM -0500, Mike Frysinger wrote:
> > On Tuesday 29 January 2008, Wolfgang Denk wrote:
> > > In message <200801282114.14393.vapier@gentoo.org> you wrote:
> > > > unfortunately, using weak symbols and overriding elsewhere doesnt
> > > > look like it's possible currently due to the way ld searches
> > > > archives. for example, if
> > >
> > > ???
> > >
> > > > ld will pick the weak symbol provided by libcommon.a even though a
> > > > strong symbol is also available in libblackfin.a :(
> > >
> > > That should never happen. What is your toolchain?
> >
> > read the binutils mailing list. this is the expected behavior of ld.
> >
> > http://sourceware.org/ml/binutils/2008-01/msg00301.html
>
> Overriding weak with strong symbols works just fine, however
> in your case ld has no reason to even look at your override,
> since it already has a (weak) definition for do_bootelf_setup().
>
> Thus the solution for your problem is to give ld a reason
> to pull in your do_bootelf_setup() definition. There are
> two ways:
>
> - explicitly list the .o file on the linker command line,
> i.e. add it to $(OBJS) or $(PLATFORM_LIBS) instead
> of libblackfin.a
>
> - put the do_bootelf_setup() definition in a .o file
> along with some other code you know will be pulled in,
> e.g. add it to lib_blackfin/cache.c instead of putting
> it in its own file
thanks ... i had created a dedicated .c file for it of only strong symbols
which would override the weaks, but as you say, with no other compelling
reason to look at the object, ld wasnt considering it
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080201/909b988b/attachment.pgp
next prev parent reply other threads:[~2008-02-01 15:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 5:50 [U-Boot-Users] [Patch] Disable icache before call the first line of kernel in do_bootelf() Sonic Zhang
2007-08-08 6:50 ` Wolfgang Denk
2007-08-08 7:21 ` Michal Simek
2007-08-08 15:47 ` [U-Boot-Users] [Patch] Disable icache before call the firstline " Robin Getz
2007-08-08 15:54 ` Wolfgang Denk
2007-08-08 18:19 ` Stefan Roese
2007-08-08 7:33 ` [U-Boot-Users] [Patch] Disable icache before call the first line " Sonic Zhang
2007-08-08 15:41 ` Wolfgang Denk
2007-08-13 14:52 ` Mike Frysinger
2007-08-13 15:50 ` Wolfgang Denk
2007-08-13 16:21 ` Mike Frysinger
2008-01-29 2:14 ` Mike Frysinger
2008-01-29 22:35 ` Wolfgang Denk
2008-01-30 0:12 ` Mike Frysinger
2008-01-30 15:36 ` Johannes Stezenbach
2008-02-01 15:42 ` Mike Frysinger [this message]
2008-02-01 15:44 ` [U-Boot-Users] [patch] allow ports to override bootelf behavior Mike Frysinger
2008-04-13 22:01 ` Wolfgang Denk
2008-02-01 15:58 ` [U-Boot-Users] [patch] allow ports to override go behavior Mike Frysinger
2008-02-01 16:36 ` Mike Frysinger
2008-04-13 22:01 ` Wolfgang Denk
2008-04-13 22:01 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802011042.20282.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox