public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 3/3] ppc4xx: HCU4/5. Cleanups
Date: Tue, 5 Feb 2008 07:46:19 +0100	[thread overview]
Message-ID: <200802050746.20173.sr@denx.de> (raw)
In-Reply-To: <200802041720.33185.sr@denx.de>

On Monday 04 February 2008, Stefan Roese wrote:
> > - Fix some coding style violations.
> > - Use in/out_u16/32 where appropriate.
> > - Use register names from ppc405.h.
> > - Fix trace useage for Lauterbach.
> > - Fix detection of vxWorks EDR.
> > - Remove obsolete generation HCU2.
> > - Renamed fixed_hcu4_sdram to init_ppc405_sdram.
>
> Thanks. Look really good now. Just a few nitpicking comments below.

And one more note regarding the 405GPr:

Could you remove the CONFIG_405GPr from your hcu4.h board config file? Please 
give it a try and if it works (which I don't doubt) then please add this to 
this patch.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-02-05  6:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-04 15:59 [U-Boot-Users] [PATCH 1/3] ppc4xx: PPC405GPr add missing EIRR register Niklaus Giger
2008-02-04 15:59 ` [U-Boot-Users] [PATCH 2/3] ppc4xx: HCU4/5. Fix make O=../xx Niklaus Giger
2008-02-04 15:59   ` [U-Boot-Users] [PATCH 3/3] ppc4xx: HCU4/5. Cleanups Niklaus Giger
2008-02-04 16:20     ` Stefan Roese
2008-02-05  6:46       ` Stefan Roese [this message]
2008-02-04 16:14 ` [U-Boot-Users] [PATCH 1/3] ppc4xx: PPC405GPr add missing EIRR register Stefan Roese
2008-02-04 16:25   ` Niklaus Giger
2008-02-05  6:41     ` Stefan Roese
2008-02-05  6:53       ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802050746.20173.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox