From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 5 Feb 2008 07:46:19 +0100 Subject: [U-Boot-Users] [PATCH 3/3] ppc4xx: HCU4/5. Cleanups In-Reply-To: <200802041720.33185.sr@denx.de> References: <12021407513585-git-send-email-niklaus.giger@netstal.com> <12021407531303-git-send-email-niklaus.giger@netstal.com> <200802041720.33185.sr@denx.de> Message-ID: <200802050746.20173.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 04 February 2008, Stefan Roese wrote: > > - Fix some coding style violations. > > - Use in/out_u16/32 where appropriate. > > - Use register names from ppc405.h. > > - Fix trace useage for Lauterbach. > > - Fix detection of vxWorks EDR. > > - Remove obsolete generation HCU2. > > - Renamed fixed_hcu4_sdram to init_ppc405_sdram. > > Thanks. Look really good now. Just a few nitpicking comments below. And one more note regarding the 405GPr: Could you remove the CONFIG_405GPr from your hcu4.h board config file? Please give it a try and if it works (which I don't doubt) then please add this to this patch. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================