From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 5 Feb 2008 07:53:37 +0100
Subject: [U-Boot-Users] [PATCH 1/3] ppc4xx: PPC405GPr add missing EIRR
	register
In-Reply-To: <200802050741.18314.sr@denx.de>
References: <12021407513585-git-send-email-niklaus.giger@netstal.com>
	<fo7e92$alu$1@ger.gmane.org> <200802050741.18314.sr@denx.de>
Message-ID: <200802050753.37686.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday 05 February 2008, Stefan Roese wrote:
> > Therefore I concluded that it is very PPC405GPr specific. But I did not
> > check all other PPC405 variants.
>
> Yes, you seem to be right here. This *is* 405GPr specific. But I don't
> think it is worth adding this CONFIG_405GPr. Right now by setting
> CONFIG_405GP in your board config file, it should work correctly on boards
> with 405GP *and* 405GPr. We shouldn't loose this "feature". So please add
> this define if CONFIG_405GP is defined. And add a comment that it is only
> valid for 405GPr.

And please use the upper case name from the users manual: CPC0_EIRR. I know 
this is not done consistently but I we should use these names for newer 
definitions since it makes it easier to match those defines with the manuals.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================