public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH v2] spi: Kill spi_chipsel table and introduce spi_setup()
Date: Tue, 5 Feb 2008 23:34:46 -0500	[thread overview]
Message-ID: <200802052334.46831.vapier@gentoo.org> (raw)
In-Reply-To: <1202214493-11719-1-git-send-email-hskinnemoen@atmel.com>

so the new SPI interface has this API:
 - void spi_init(void);
 - int spi_setup(int cs, unsigned int max_hz, unsigned int mode);
 - int spi_xfer(int cs, int bitlen, uchar *dout, uchar *din);
 - int spi_cs_is_valid(int cs);
 - void spi_cs_activate(int cs);
 - void spi_cs_deactivate(int cs);

there isnt a function to pair up with spi_setup() ?  for example, the normal 
communication flow with a SPI flash:
 - spi_setup - turn on SPI
 - spi_cs_activate - assert CS
 - spi_xfer -
	- op code (read/write/erase)
	- address
	- actual block data
 - spi_cs_deactivate - deassert CS
 - ??? - turn off SPI
you dont want to have the deactivate func to turn off SPI in case you need to 
toggle the CS during communication ... some SPI peripherals have undefined 
(floating) behavior with pins when it is actually turned off which is bad 
mojo ...

also, what's the deal with spi_xfer() taking a length in # of bits ?  is it 
realistic to transmit anything less tan 8 bits ?  the Linux kernel driver 
does not support this, so it cant be a big need ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080205/47ed3ca7/attachment.pgp 

  parent reply	other threads:[~2008-02-06  4:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 12:28 [U-Boot-Users] [PATCH v2] spi: Kill spi_chipsel table and introduce spi_setup() Haavard Skinnemoen
2008-02-05 12:53 ` Joakim Tjernlund
2008-02-05 16:51 ` Ben Warren
2008-02-06  4:34 ` Mike Frysinger [this message]
2008-02-06  9:50   ` Haavard Skinnemoen
2008-02-06 13:45     ` Mike Frysinger
2008-02-06 15:18     ` Ben Warren
2008-02-06 15:39       ` Haavard Skinnemoen
2008-02-06 15:57       ` Mike Frysinger
2008-02-06 16:22         ` Ben Warren
2008-02-06 16:58           ` Ulf Samuelsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802052334.46831.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox