public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] 440EPX is not booting from 1Gb/128MB NAND flash
Date: Tue, 12 Feb 2008 07:02:46 +0100	[thread overview]
Message-ID: <20080212060246.2832424050@gemini.denx.de> (raw)
In-Reply-To: Your message of "Tue, 12 Feb 2008 06:12:46 +0100." <200802120612.46861.sr@denx.de>

In message <200802120612.46861.sr@denx.de> you wrote:
>
> This is set to 512 for small page devices and set to 2k for large page 
> devices. So the code can be "selected" via this #if statement:
> 
> #if (CFG_NAND_PAGE_SIZE > 512)

Please use an explicit test instead, i. e. for example

	#if (CFG_NAND_PAGE_SIZE == 2048)

unless you are absolutley sure that all future devices (say, with 8k
or 8k page sizes) will behave identical. Otherwise it will be a mess
to clean up that code later.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
        Ordnung ist die Lust der Vernunft,
        aber Unordnung die Wonne der Phantasie         - Paul Claudel

  reply	other threads:[~2008-02-12  6:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <e9eeaac20802061636t14229054yebb41fa38dc5bffe@mail.gmail.com>
2008-02-07  0:38 ` [U-Boot-Users] 440EPX is not booting from 1Gb/128MB NAND flash Nikhil Gautam
2008-02-07  5:24   ` Stefan Roese
2008-02-07 23:46     ` Nikhil Gautam
2008-02-08  4:50       ` Stefan Roese
2008-02-08 22:57         ` Nikhil Gautam
2008-02-09  5:51           ` Stefan Roese
2008-02-11 14:43           ` Nikhil Gautam
2008-02-11 16:26             ` Stefan Roese
2008-02-12  1:16               ` Nikhil Gautam
2008-02-12  5:12                 ` Stefan Roese
2008-02-12  6:02                   ` Wolfgang Denk [this message]
2008-02-12  6:11                     ` Stefan Roese
2008-02-12 22:31                       ` Wolfgang Denk
2008-02-13 23:16                         ` Nikhil Gautam
2008-02-14  5:36                           ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080212060246.2832424050@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox