From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 12 Feb 2008 07:11:16 +0100
Subject: [U-Boot-Users] 440EPX is not booting from 1Gb/128MB NAND flash
In-Reply-To: <20080212060246.2832424050@gemini.denx.de>
References: <20080212060246.2832424050@gemini.denx.de>
Message-ID: <200802120711.17212.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday 12 February 2008, Wolfgang Denk wrote:
> > #if (CFG_NAND_PAGE_SIZE > 512)
>
> Please use an explicit test instead, i. e. for example
>
> 	#if (CFG_NAND_PAGE_SIZE == 2048)
>
> unless you are absolutley sure that all future devices (say, with 8k
> or 8k page sizes) will behave identical. Otherwise it will be a mess
> to clean up that code later.

I got my idea from the current Linux MTD NAND drivers (and U-Boot btw). Here 
the distinction between small page and large page devices is done this way:

if (mtd->writesize > 512)
	lp..
else
	sp..

That's why I still prefer my suggestion.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================