U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/3] fdt: Fixup compile error and add a new OF manipulation option
Date: Tue, 12 Feb 2008 16:26:34 +0100	[thread overview]
Message-ID: <200802121626.34928.sr@denx.de> (raw)
In-Reply-To: <47B1B40F.3040301@ge.com>

Hi Jerry,

On Tuesday 12 February 2008, Jerry Van Baren wrote:
> I think you have an older version of fdt_support.c.  Check the latest
> version - the above check is no longer in there.  That was a change that
> went in towards the end of the last patch window.
>
> <http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=common/fdt_sup
>port.c;h=92f1c7f54fd5e62942c8496bde52639e420067c1;hb=HEAD>
>
> The patch that changed this:
> <http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=b60af3d4
>c1680487ee37e11aa1b3db6dec04d8f0>
>
> It is possible we have some other wires crossed as well.  There was a
> fair amount of LIBFDT support refactoring going on in the last patch
> window, so we may have missed some deletions related to refactoring that
> should have been made.

I have to admit, that without looking too deep into the fdt code, I don't see 
a way to set the force flag upon Linux booting. Here the code from 
common/cmd_bootm.c:

        /*
         * Add the chosen node if it doesn't exist, add the env and bd_t
         * if the user wants it (the logic is in the subroutines).
         */
        if (of_flat_tree) {
                if (fdt_chosen(of_flat_tree, initrd_start, initrd_end, 0) < 0)

As you can see, the force flag is always set to 0. So how should "force" the 
chosen node manipulation? Perhaps I'm missing something here.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
=====================================================================

  reply	other threads:[~2008-02-12 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12  1:11 [U-Boot-Users] [PATCH 2/3] fdt: Fixup compile error and add a new OF manipulation option Bryan O'Donoghue
2008-02-12 13:27 ` Jerry Van Baren
2008-02-12 14:16   ` Bryan O'Donoghue
2008-02-12 14:58     ` Jerry Van Baren
2008-02-12 15:26       ` Stefan Roese [this message]
2008-02-12 16:12       ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802121626.34928.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox