public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined
Date: Thu, 14 Feb 2008 00:59:53 +0100	[thread overview]
Message-ID: <20080213235953.9EBBD243A7@gemini.denx.de> (raw)
In-Reply-To: Your message of "Mon, 04 Feb 2008 17:32:56 PST." <15281823.post@talk.nabble.com>

In message <15281823.post@talk.nabble.com> you wrote:
> 
> At Present the call to "cpu_init_crit" in uboot/cpu/arm926ejs/start.S (142)
> is under ifndef
> 
> #ifndef CONFIG_SKIP_LOWLEVEL_INIT
> 	bl	cpu_init_crit
> #endif
> 
>   But the function definition (203) isn't under this ifndef. So irrespective
> of CONFIG_SKIP_LOWLEVEL_INIT, this function is compiled. Hence i have
> applied the ifndef to function definition which places the entire
> cpu_init_crit inside the ifndef.

I don't think you answer my question:

> I'm not sure about this one. Probably the whole  cpu_init_crit:  part
> should be placed inside the "#ifndef CONFIG_SKIP_LOWLEVEL_INIT" part,
> as it is done for example in "cpu/arm920t/start.S" ?

?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The years of peak mental activity are undoubtedly between the ages of
four and eighteen. At four we know all the questions, at eighteen all
the answers.

  reply	other threads:[~2008-02-13 23:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-18 23:52 [U-Boot-Users] [PATCH] ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined Hebbar
2007-12-18 23:59 ` Hebbar
2007-12-19  6:27   ` Dirk Behme
2008-02-04 22:38   ` Wolfgang Denk
2008-02-05  1:32     ` Hebbar
2008-02-13 23:59       ` Wolfgang Denk [this message]
2008-02-14  0:19         ` Hebbar
  -- strict thread matches above, loose matches on Subject: below --
2007-12-19  8:48 Gururaja Hebbar K R
2007-12-19  8:58 ` Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080213235953.9EBBD243A7@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox