From: Michael Schwingen <michael@schwingen.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c
Date: Mon, 18 Feb 2008 23:16:35 +0100 [thread overview]
Message-ID: <20080218221634.GA27687@discworld.dascon.de> (raw)
In-Reply-To: <200802041705.10934.sr@denx.de>
>
> Right. But it will be an improvement to the current implementation, where a
> random command is written as RESET command. And also an improvement to the
> fixed AMD/Intel RESET command. So I vote for trying this solution. I'll test
> on a few of mine platforms too.
>
> Michael, could please you provide a patch?
Okay - sorry, I did not have time for as much testing as I planned.
From a short test, it looks like AMD-style flash roms treat *any* unknown
command write as a reset, at least when in CFI Query mode, so issuing the
Intel reset command to AMD-style flashs seems safe (from the small sample I
have), plus the 3-cycle magic sequence should kick the state machine into
the right state even without a reset command. Since the AMD-style flashs
require the unlock sequence for real operation, I chose to try the AMD reset
command first, so that Intel flashs do no see an invalid command prior to
the CFI query.
I have tested the patch on AM29LV320-style flashs from Fujitsu and Macronix,
plus Intel StrataFlash.
cu
Michael
next prev parent reply other threads:[~2008-02-18 22:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 3:27 [U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c Mike Frysinger
2008-01-29 6:15 ` Stefan Roese
2008-01-29 13:05 ` Mike Frysinger
2008-01-29 13:13 ` Stefan Roese
2008-02-03 15:56 ` Michael Schwingen
2008-02-04 10:13 ` Stefan Roese
2008-02-04 15:48 ` Michael Schwingen
2008-02-04 16:05 ` Stefan Roese
2008-02-05 9:45 ` Michael Schwingen
2008-02-05 9:52 ` Stefan Roese
2008-02-18 22:16 ` Michael Schwingen [this message]
2008-02-20 9:18 ` Stefan Roese
2008-02-20 9:50 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080218221634.GA27687@discworld.dascon.de \
--to=michael@schwingen.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox