public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] net/Blackfin: move on-chip MAC driver into drivers/net/
Date: Wed, 27 Feb 2008 04:58:23 -0500	[thread overview]
Message-ID: <200802270458.24492.vapier@gentoo.org> (raw)
In-Reply-To: <20080227105218.63b4ccc1@hskinnemoen.norway.atmel.com>

On Wednesday 27 February 2008, Haavard Skinnemoen wrote:
> Mike Frysinger <vapier@gentoo.org> wrote:
> > The Blackfin on-chip MAC driver was being managed in the BF537-STAMP
> > board directory, but it is not board specific, so relocate it to the
> > drivers dir so that other Blackfin ports can utilize it.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> >  board/bf537-stamp/Makefile      |    2 +-
> >  board/bf537-stamp/ether_bf537.c |  549
> > --------------------------------------- board/bf537-stamp/ether_bf537.h |
> >   71 -----
> >  drivers/net/Makefile            |    1 +
> >  drivers/net/bfin_mac.c          |  523
> > +++++++++++++++++++++++++++++++++++++ drivers/net/bfin_mac.h          |  
> > 89 +++++++
> >  6 files changed, 614 insertions(+), 621 deletions(-)
> >  delete mode 100644 board/bf537-stamp/ether_bf537.c
> >  delete mode 100644 board/bf537-stamp/ether_bf537.h
> >  create mode 100644 drivers/net/bfin_mac.c
> >  create mode 100644 drivers/net/bfin_mac.h
>
> No objections from me, but I think it would be easier to review such
> patches if you generated them with git-format-patch -M or something
> similar.

thanks, i wasnt aware of that flag

> That makes the patch show the actual changes to the files 
> without all the rename noise.

in the case of the bfin_mac, the changes are minuscule: fix style in a place 
or two and delete dead code.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080227/67865df0/attachment.pgp 

  reply	other threads:[~2008-02-27  9:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25  4:58 [U-Boot-Users] [PATCH] net/Blackfin: move on-chip MAC driver into drivers/net/ Mike Frysinger
2008-02-27  9:52 ` Haavard Skinnemoen
2008-02-27  9:58   ` Mike Frysinger [this message]
2008-02-27 16:14     ` Ben Warren
2008-03-25 21:36 ` Wolfgang Denk
2008-03-30 20:04   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802270458.24492.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox