public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH] fix taihu soft spi_read
@ 2008-03-05 20:38 Markus Brunner
  2008-03-07  8:21 ` Stefan Roese
  0 siblings, 1 reply; 2+ messages in thread
From: Markus Brunner @ 2008-03-05 20:38 UTC (permalink / raw)
  To: u-boot

The taihu board used gpio_read_out_bit which reads the output register and not 
the pin state.

Signed-off-by: Markus Brunner <super.firetwister@gmail.com>
---

The function gpio_read_out_bit didn't exist in u-boot <= 1.3.1 so every usage 
of gpio_read_out_bit deserves a closer look.

diff --git a/board/amcc/taihu/taihu.c b/board/amcc/taihu/taihu.c
index ea83671..eedde59 100644
--- a/board/amcc/taihu/taihu.c
+++ b/board/amcc/taihu/taihu.c
@@ -162,7 +162,7 @@ void spi_sda(int bit)

 unsigned char spi_read(void)
 {
-       return (unsigned char)gpio_read_out_bit(SPI_DIN_GPIO15);
+       return (unsigned char)gpio_read_in_bit(SPI_DIN_GPIO15);
 }

 void taihu_spi_chipsel(int cs)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot-Users] [PATCH] fix taihu soft spi_read
  2008-03-05 20:38 [U-Boot-Users] [PATCH] fix taihu soft spi_read Markus Brunner
@ 2008-03-07  8:21 ` Stefan Roese
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Roese @ 2008-03-07  8:21 UTC (permalink / raw)
  To: u-boot

On Wednesday 05 March 2008, Markus Brunner wrote:
> The taihu board used gpio_read_out_bit which reads the output register and
> not the pin state.

Applied to u-boot-ppc4xx custodian repository. Will get pulled into 1.3.2 
release. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-07  8:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-05 20:38 [U-Boot-Users] [PATCH] fix taihu soft spi_read Markus Brunner
2008-03-07  8:21 ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox