public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add support for hammerhead AVR32 board
Date: Fri, 14 Mar 2008 16:54:09 +0100	[thread overview]
Message-ID: <20080314155409.C2DE3247AF@gemini.denx.de> (raw)
In-Reply-To: Your message of "Fri, 14 Mar 2008 16:19:06 +0100." <47DA976A.6000309@miromico.ch>

In message <47DA976A.6000309@miromico.ch> you wrote:
>
> This patch adds support for our new AVR32 based board.
...
> diff -Nur old/u-boot-avr32/cpu/at32ap/at32ap700x/gpio.c new/u-boot-avr32/cpu/at32ap/at32ap700x/gpio.c
> --- old/u-boot-avr32/cpu/at32ap/at32ap700x/gpio.c	2008-03-14 14:40:30.000000000 +0100
> +++ new/u-boot-avr32/cpu/at32ap/at32ap700x/gpio.c	2008-03-14 15:34:43.000000000 +0100
> @@ -142,3 +142,14 @@
>   	gpio_select_periph_A(GPIO_PIN_PA15, 0);	/* DATA3 */
>   }
>   #endif
> +
> +#ifdef CONFIG_HAMMERHEAD
> +/*
> + * Hammerhead board uses GCLK3 (Periph A on PB29) as 25MHz clock output
> + * for ethernet PHY.
> + */
> +void gpio_enable_gclk3(void)
> +{
> +        gpio_select_periph_A(GPIO_PIN_PB29, 0); /* GCLK3         */
  ^^^^^^^^^^

Indentation not by TAB.

> --- old/u-boot-avr32/net/eth.c	2008-03-14 14:40:32.000000000 +0100
> +++ new/u-boot-avr32/net/eth.c	2008-03-14 16:04:58.000000000 +0100
> @@ -64,6 +64,7 @@
>   extern int mcffec_initialize(bd_t*);
>   extern int mcdmafec_initialize(bd_t*);
>   extern int at91cap9_eth_initialize(bd_t *);
> +extern int board_eth_initialize(bd_t *);
> 
>   #ifdef CONFIG_API
>   extern void (*push_packet)(volatile void *, int);
> @@ -288,6 +289,8 @@
>   	at91cap9_eth_initialize(bis);
>   #endif
> 
> +	board_eth_initialize(bis);
> +

Hm... did you really check if other boards still build? Did  you  run
the MAKEALL script?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quote from a recent meeting:   "We are going to continue having these
meetings everyday until I find out why no work is getting done."

  reply	other threads:[~2008-03-14 15:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14 15:19 [U-Boot-Users] [PATCH] Add support for hammerhead AVR32 board Alex
2008-03-14 15:54 ` Wolfgang Denk [this message]
2008-03-17 10:31   ` Alex
2008-03-17 10:38     ` Jean-Christophe PLAGNIOL-VILLARD
2008-03-26 13:57     ` Haavard Skinnemoen
2008-03-30 23:41     ` Ben Warren
2008-04-06 23:13       ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080314155409.C2DE3247AF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox