[U-Boot-Users] [PATCH 3/7] 83xx: serdes setup routines

[Anton Vorontsov <avorontsov@ru.mvista.com>]

On Tue, Mar 18, 2008 at 11:28:20AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 23:19 Fri 14 Mar     , Anton Vorontsov wrote:
> > This patch adds few routines to configure serdes on 837x targets.
> > 
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> > ---
> >  cpu/mpc83xx/Makefile         |    1 +
> >  cpu/mpc83xx/serdes.c         |  156 ++++++++++++++++++++++++++++++++++++++++++
> >  include/asm-ppc/fsl_serdes.h |   25 +++++++
> >  3 files changed, 182 insertions(+), 0 deletions(-)
> >  create mode 100644 cpu/mpc83xx/serdes.c
> >  create mode 100644 include/asm-ppc/fsl_serdes.h
> > 
> > diff --git a/cpu/mpc83xx/Makefile b/cpu/mpc83xx/Makefile
> > index 7ad7e3e..6b6b027 100644
> > --- a/cpu/mpc83xx/Makefile
> > +++ b/cpu/mpc83xx/Makefile
> > @@ -39,6 +39,7 @@ COBJS-y += ecc.o
> >  COBJS-$(CONFIG_QE) += qe_io.o
> >  COBJS-$(CONFIG_83XX_GENERIC_PCI) += pci.o
> >  COBJS-$(CONFIG_OF_LIBFDT) += fdt.o
> > +COBJS-$(CONFIG_FSL_SERDES) += serdes.o
> Please keep it sort

Keeping cobjs in alphabetical order sounds weird to me, plus as
far as I can see, current Makefile tried to keep things in this
(sane) order:

start.S
COBJS += core (traps, cpu)
COBJS += "less" important code (speed, sdram, ..)
COBJS += auxiliary/not so important (pci, fdt, ....)

[Almost] the same order in which the code will be executed.

Though, in this case I should place SERDES above FDT, near the PCI.


Anyhow, firstly I'd like to know what Kim is thinking about all
this?

-- 
Anton Vorontsov
email: cboumailru at gmail.com
irc://irc.freenode.net/bd2