From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/7] 83xx: nand support for MPC837XRDB boards
Date: Wed, 19 Mar 2008 20:16:45 -0500 [thread overview]
Message-ID: <20080319201645.88467c0e.kim.phillips@freescale.com> (raw)
In-Reply-To: <20080318141055.GA28688@localhost.localdomain>
On Tue, 18 Mar 2008 17:10:55 +0300
Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
>
> > > -/* VSC7385 Gigabit Switch support */
> > > +/*
> > > + * VSC7385 Gigabit Switch support
> > > + */
> > > +#define CFG_VSC7385_BASE 0xF0000000
> >
> > What does this have to do with NAND?
>
> Nothing. I'm expanding VSC7385 comment to better separate it from
> the NAND code. Most lengthy parts of the RDB config are using
>
> /*
> *
> */
>
> as a logical separator. So did I.
that's fine, it just makes patch review easier and less susceptible to
comments like this if you keep your patches on-subject.
Also, this patch doesn't apply cleanly to the top of
u-boot-mpc83xx.git, because of the VSC7385 patches I applied last week.
Can you rebase your patches to the top of the mpc83xx git tree? I just
updated it to Wolfgang's top-of-tree.
Kim
next prev parent reply other threads:[~2008-03-20 1:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 20:19 [U-Boot-Users] [PATCH 1/7] 83xx: nand support for MPC837XRDB boards Anton Vorontsov
2008-03-17 23:02 ` Scott Wood
2008-03-18 14:10 ` Anton Vorontsov
2008-03-20 1:16 ` Kim Phillips [this message]
2008-03-20 16:26 ` Scott Wood
2008-03-20 16:31 ` Anton Vorontsov
2008-03-21 15:30 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080319201645.88467c0e.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox