public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] ppc4xx: Don't use last 256 bytes of SDRAM, workaround for 440EPx CHIP 11 errata
Date: Thu, 20 Mar 2008 11:29:06 +0100	[thread overview]
Message-ID: <200803201129.06602.sr@denx.de> (raw)
In-Reply-To: <20080320100330.B00C624A87@gemini.denx.de>

Hi Wolfgang,

On Thursday 20 March 2008, Wolfgang Denk wrote:
> > This patch adds this workaround for the following 440EPx boards:
> > sequoia, lwmon5. Others should probably follow this example.
>
> OK, the default configs for Sequoia doesn't use shared log buffer, and
> the lwmon5 uses CONFIG_ALT_LB_ADDR (i. e. it puts the log buffer in
> OCM), so these boards will work.
>
> But any changes to the configuration may easily break this again.

Understood.

> I don't like the idea that  each  affected  board  has  to  fix  this
> (probably  differently)  in  it's board config file. I would prefer a
> fix (common to all affected boards) in one central location.

I don't like this either. But I have not come up with a "generic" solution 
till now. It's not so easy since the 440EPx SDRAM setup code is sometimes 
common (cpu/ppc4xx/denali_spd_ddr2.c) and sometimes board specific. And it 
gets even more complicated when ECC initialization is needed too. So 
currently I have no "better" solution as to do it in a board specific way.

As always, patches implementing a "better" more generic solution are welcome.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-03-20 10:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-20  9:46 [U-Boot-Users] [PATCH] ppc4xx: Don't use last 256 bytes of SDRAM, workaround for 440EPx CHIP 11 errata Stefan Roese
2008-03-20 10:03 ` Wolfgang Denk
2008-03-20 10:29   ` Stefan Roese [this message]
2008-03-20 11:16     ` Wolfgang Denk
2008-03-20 12:55       ` Kumar Gala
2008-03-20 13:57       ` Stefan Roese
2008-03-20 11:50     ` Dave Littell
2008-03-20 14:11       ` Stefan Roese
2008-03-20 16:06     ` Larry Johnson
2008-03-20 21:12       ` Stefan Roese
2008-03-27  2:50         ` Larry Johnson
2008-03-27  6:21           ` Stefan Roese
2008-03-27 18:36             ` Larry Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803201129.06602.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox