* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
@ 2008-03-20 11:54 Sascha Laue
2008-03-20 12:00 ` Markus Klotzbücher
0 siblings, 1 reply; 11+ messages in thread
From: Sascha Laue @ 2008-03-20 11:54 UTC (permalink / raw)
To: u-boot
Hi all,
we modified the specification for the lwmon5 board dspic POST.
Additionally I have add defines for the temperature- and voltagevalues.
Signed-of-by: Sascha Laue <sascha.laue@liebherr.com>
Signed-of-by: Marcel Brasch <marcel.brasch@liebherr.com>
@@ -34,9 +34,10 @@
* The test passes when all the following voltages and temperatures
* are within allowed ranges:
*
- * Temperature -40 .. +85 C
- * +5V +4.75 .. +5.25 V
- * +5V standby +4.75 .. +5.25 V
+ * Temperature -40 .. +90 ?C
+ * Tempreature_Display -35 .. +85 ?C
+ * +5V +4.50 .. +5.50 V
+ * +5V standby +3.50 .. +5.50 V
*
* LCD backlight is not enabled if temperature values are not within
* allowed ranges (-30 .. + 80). The brightness of backlite can be
@@ -62,6 +63,21 @@
#define RELOC(x) if (x != NULL) x = (void *) ((ulong) (x) + gd->reloc_off)
+#define REG_TEMPERATURE 0x12BC
+#define REG_VOLTAGE_5V 0x12CA
+#define REG_VOLTAGE_5V_STANDBY 0x12C6
+
+#define TEMPERATURE_MIN (-40) /* ?C */
+#define TEMPERATURE_MAX (+90) /* ?C */
+#define TEMPERATURE_DISPLAY_MIN (-35) /* ?C */
+#define TEMPERATURE_DISPLAY_MAX (+85) /* ?C */
+
+#define VOLTAGE_5V_MIN (+4500) /* mV */
+#define VOLTAGE_5V_MAX (+5500) /* mV */
+
+#define VOLTAGE_5V_STANDBY_MIN (+3500) /* mV */
+#define VOLTAGE_5V_STANDBY_MAX (+5500) /* mV */
+
typedef struct sysmon_s sysmon_t;
typedef struct sysmon_table_s sysmon_table_t;
@@ -110,16 +126,22 @@
static sysmon_table_t sysmon_table[] =
{
{"Temperature", " C", &sysmon_dspic, NULL, sysmon_backlight_disable,
- 1, 1, -32768, 32767, 0xFFFF, 0x8000-40, 0x8000+85, 0,
- 0x8000-30, 0x8000+80, 0, 0x12BC},
+ 1, 1, -0x8000, 0x7FFF, 0xFFFF,
+ 0x8000 + TEMPERATURE_MIN , 0x8000 + TEMPERATURE_MAX , 0,
+ 0x8000 + TEMPERATURE_DISPLAY_MIN, 0x8000 + TEMPERATURE_DISPLAY_MAX, 0,
+ REG_TEMPERATURE},
{"+ 5 V", "V", &sysmon_dspic, NULL, NULL,
- 100, 1000, -0x8000, 0x7FFF, 0xFFFF, 0x8000+4750, 0x8000+5250, 0,
- 0x8000+4750, 0x8000+5250, 0, 0x12CA},
+ 100, 1000, -0x8000, 0x7FFF, 0xFFFF,
+ 0x8000 + VOLTAGE_5V_MIN , 0x8000 + VOLTAGE_5V_MAX, 0,
+ 0x8000 + VOLTAGE_5V_MIN , 0x8000 + VOLTAGE_5V_MAX, 0,
+ REG_VOLTAGE_5V},
{"+ 5 V standby", "V", &sysmon_dspic, NULL, NULL,
- 100, 1000, -0x8000, 0x7FFF, 0xFFFF, 0x8000+4750, 0x8000+5250, 0,
- 0x8000+4750, 0x8000+5250, 0, 0x12C6},
+ 100, 1000, -0x8000, 0x7FFF, 0xFFFF,
+ 0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0,
+ 0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0,
+ REG_VOLTAGE_5V_STANDBY},
};
static int sysmon_table_size = sizeof(sysmon_table) / sizeof(sysmon_table[0]);
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
2008-03-20 11:54 [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification Sascha Laue
@ 2008-03-20 12:00 ` Markus Klotzbücher
2008-03-20 12:05 ` Sascha Laue
0 siblings, 1 reply; 11+ messages in thread
From: Markus Klotzbücher @ 2008-03-20 12:00 UTC (permalink / raw)
To: u-boot
Dear Sascha,
"Sascha Laue" <saschalaue@gmx.net> writes:
> we modified the specification for the lwmon5 board dspic POST.
> Additionally I have add defines for the temperature- and voltagevalues.
>
> Signed-of-by: Sascha Laue <sascha.laue@liebherr.com>
> Signed-of-by: Marcel Brasch <marcel.brasch@liebherr.com>
>
> @@ -34,9 +34,10 @@
> * The test passes when all the following voltages and temperatures
> * are within allowed ranges:
Ups. It seems you forgot to copy the patch header.
Best regards
Markus Klotzbuecher
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
2008-03-20 12:00 ` Markus Klotzbücher
@ 2008-03-20 12:05 ` Sascha Laue
2008-03-25 23:18 ` Wolfgang Denk
0 siblings, 1 reply; 11+ messages in thread
From: Sascha Laue @ 2008-03-20 12:05 UTC (permalink / raw)
To: u-boot
Ups.
Best regards
Sascha Laue
diff -u -r -N u-boot/post/board/lwmon5/sysmon.c u-boot-mod/post/board/lwmon5/sysmon.c
--- u-boot/post/board/lwmon5/sysmon.c 2008-03-19 15:33:26.000000000 +0100
+++ u-boot-mod/post/board/lwmon5/sysmon.c 2008-03-20 08:55:10.000000000 +0100
@@ -34,9 +34,10 @@
* The test passes when all the following voltages and temperatures
* are within allowed ranges:
*
- * Temperature -40 .. +85 C
- * +5V +4.75 .. +5.25 V
- * +5V standby +4.75 .. +5.25 V
+ * Temperature -40 .. +90 ?C
+ * Tempreature_Display -35 .. +85 ?C
+ * +5V +4.50 .. +5.50 V
+ * +5V standby +3.50 .. +5.50 V
*
* LCD backlight is not enabled if temperature values are not within
* allowed ranges (-30 .. + 80). The brightness of backlite can be
@@ -62,6 +63,21 @@
#define RELOC(x) if (x != NULL) x = (void *) ((ulong) (x) + gd->reloc_off)
+#define REG_TEMPERATURE 0x12BC
+#define REG_VOLTAGE_5V 0x12CA
+#define REG_VOLTAGE_5V_STANDBY 0x12C6
+
+#define TEMPERATURE_MIN (-40) /* ?C */
+#define TEMPERATURE_MAX (+90) /* ?C */
+#define TEMPERATURE_DISPLAY_MIN (-35) /* ?C */
+#define TEMPERATURE_DISPLAY_MAX (+85) /* ?C */
+
+#define VOLTAGE_5V_MIN (+4500) /* mV */
+#define VOLTAGE_5V_MAX (+5500) /* mV */
+
+#define VOLTAGE_5V_STANDBY_MIN (+3500) /* mV */
+#define VOLTAGE_5V_STANDBY_MAX (+5500) /* mV */
+
typedef struct sysmon_s sysmon_t;
typedef struct sysmon_table_s sysmon_table_t;
@@ -110,16 +126,22 @@
static sysmon_table_t sysmon_table[] =
{
{"Temperature", " C", &sysmon_dspic, NULL, sysmon_backlight_disable,
- 1, 1, -32768, 32767, 0xFFFF, 0x8000-40, 0x8000+85, 0,
- 0x8000-30, 0x8000+80, 0, 0x12BC},
+ 1, 1, -0x8000, 0x7FFF, 0xFFFF,
+ 0x8000 + TEMPERATURE_MIN , 0x8000 + TEMPERATURE_MAX , 0,
+ 0x8000 + TEMPERATURE_DISPLAY_MIN, 0x8000 + TEMPERATURE_DISPLAY_MAX, 0,
+ REG_TEMPERATURE},
{"+ 5 V", "V", &sysmon_dspic, NULL, NULL,
- 100, 1000, -0x8000, 0x7FFF, 0xFFFF, 0x8000+4750, 0x8000+5250, 0,
- 0x8000+4750, 0x8000+5250, 0, 0x12CA},
+ 100, 1000, -0x8000, 0x7FFF, 0xFFFF,
+ 0x8000 + VOLTAGE_5V_MIN , 0x8000 + VOLTAGE_5V_MAX, 0,
+ 0x8000 + VOLTAGE_5V_MIN , 0x8000 + VOLTAGE_5V_MAX, 0,
+ REG_VOLTAGE_5V},
{"+ 5 V standby", "V", &sysmon_dspic, NULL, NULL,
- 100, 1000, -0x8000, 0x7FFF, 0xFFFF, 0x8000+4750, 0x8000+5250, 0,
- 0x8000+4750, 0x8000+5250, 0, 0x12C6},
+ 100, 1000, -0x8000, 0x7FFF, 0xFFFF,
+ 0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0,
+ 0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0,
+ REG_VOLTAGE_5V_STANDBY},
};
static int sysmon_table_size = sizeof(sysmon_table) / sizeof(sysmon_table[0]);
-------- Original-Nachricht --------
> Datum: Thu, 20 Mar 2008 13:00:26 +0100
> Von: "Markus Klotzb?cher" <mk@denx.de>
> An: "Sascha Laue" <saschalaue@gmx.net>
> CC: u-boot-users at lists.sourceforge.net
> Betreff: Re: [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
> Dear Sascha,
>
> "Sascha Laue" <saschalaue@gmx.net> writes:
>
> > we modified the specification for the lwmon5 board dspic POST.
> > Additionally I have add defines for the temperature- and voltagevalues.
> >
> > Signed-of-by: Sascha Laue <sascha.laue@liebherr.com>
> > Signed-of-by: Marcel Brasch <marcel.brasch@liebherr.com>
> >
> > @@ -34,9 +34,10 @@
> > * The test passes when all the following voltages and temperatures
> > * are within allowed ranges:
>
> Ups. It seems you forgot to copy the patch header.
>
> Best regards
>
> Markus Klotzbuecher
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
2008-03-20 12:05 ` Sascha Laue
@ 2008-03-25 23:18 ` Wolfgang Denk
2008-04-01 7:56 ` Sascha Laue
0 siblings, 1 reply; 11+ messages in thread
From: Wolfgang Denk @ 2008-03-25 23:18 UTC (permalink / raw)
To: u-boot
In message <20080320120557.182790@gmx.net> you wrote:
> Ups.
>
> Best regards
>
> Sascha Laue
>
> diff -u -r -N u-boot/post/board/lwmon5/sysmon.c u-boot-mod/post/board/lwmon=
> 5/sysmon.c
Sorry, but this patch does not apply:
Applying lwmon5: update dsPIC POST spezification
.dotest/patch:29: trailing whitespace.
#define TEMPERATURE_DISPLAY_MAX (+85) /* ?C */
.dotest/patch:46: trailing whitespace.
1, 1, -0x8000, 0x7FFF, 0xFFFF,
.dotest/patch:48: trailing whitespace.
0x8000 + TEMPERATURE_DISPLAY_MIN, 0x8000 +
TEMPERATURE_DISPLAY_MAX, 0,
.dotest/patch:54: trailing whitespace.
100, 1000, -0x8000, 0x7FFF, 0xFFFF,
.dotest/patch:56: trailing whitespace.
0x8000 + VOLTAGE_5V_MIN , 0x8000 + VOLTAGE_5V_MAX, 0,
error: patch failed: post/board/lwmon5/sysmon.c:110
error: post/board/lwmon5/sysmon.c: patch does not apply
fatal: sha1 information is lacking or useless
(post/board/lwmon5/sysmon.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001.
Please cleanup the code (whitespace issues), and use git-format-patch
and git-send-email to post a clean, usable patch.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A failure will not appear until a unit has passed final inspection.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
2008-03-25 23:18 ` Wolfgang Denk
@ 2008-04-01 7:56 ` Sascha Laue
2008-04-01 8:10 ` Sascha Laue
2008-04-28 20:41 ` Wolfgang Denk
0 siblings, 2 replies; 11+ messages in thread
From: Sascha Laue @ 2008-04-01 7:56 UTC (permalink / raw)
To: u-boot
Hello Wolfgang,
sorry but it's the first time for me.
let's try again.
we modified the specification for the lwmon5 board dspic POST.
Additionally I have add defines for the temperature- and voltagevalues.
Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
---
post/board/lwmon5/sysmon.c | 39 ++++++++++++++++++++++++++++++---------
1 files changed, 30 insertions(+), 9 deletions(-)
diff --git a/post/board/lwmon5/sysmon.c b/post/board/lwmon5/sysmon.c
--- a/post/board/lwmon5/sysmon.c
index 0cf1cf2..77e7ea2 100644
+++ b/post/board/lwmon5/sysmon.c
@@ -34,9 +34,9 @@
* The test passes when all the following voltages and temperatures
* are within allowed ranges:
*
- * Temperature -40 .. +85 C
- * +5V +4.75 .. +5.25 V
- * +5V standby +4.75 .. +5.25 V
+ * Temperature -40 .. +90 C
+ * +5V +4.50 .. +5.50 V
+ * +5V standby +3.50 .. +5.50 V
*
* LCD backlight is not enabled if temperature values are not within
* allowed ranges (-30 .. + 80). The brightness of backlite can be
@@ -62,6 +62,21 @@ extern int dspic_read(ushort reg, ushort *data);
#define RELOC(x) if (x != NULL) x = (void *) ((ulong) (x) + gd->reloc_off)
+#define REG_TEMPERATURE 0x12BC
+#define REG_VOLTAGE_5V 0x12CA
+#define REG_VOLTAGE_5V_STANDBY 0x12C6
+
+#define TEMPERATURE_MIN (-40) /* C */
+#define TEMPERATURE_MAX (+90) /* C */
+#define TEMPERATURE_DISPLAY_MIN (-35) /* C */
+#define TEMPERATURE_DISPLAY_MAX (+85) /* C */
+
+#define VOLTAGE_5V_MIN (+4500) /* mV */
+#define VOLTAGE_5V_MAX (+5500) /* mV */
+
+#define VOLTAGE_5V_STANDBY_MIN (+3500) /* mV */
+#define VOLTAGE_5V_STANDBY_MAX (+5500) /* mV */
+
typedef struct sysmon_s sysmon_t;
typedef struct sysmon_table_s sysmon_table_t;
@@ -115,16 +130,22 @@ struct sysmon_table_s
static sysmon_table_t sysmon_table[] =
{
{"Temperature", " C", &sysmon_dspic_sgn, NULL, sysmon_backlight_disable,
- 1, 1, -32768, 32767, 0xFFFF, 0x8000-40, 0x8000+85, 0,
- 0x8000-30, 0x8000+80, 0, 0x12BC},
+ 1, 1, -32768, 32767, 0xFFFF,
+ 0x8000 + TEMPERATURE_MIN, 0x8000 + TEMPERATURE_MAX, 0,
+ 0x8000 + TEMPERATURE_DISPLAY_MIN, 0x8000 + TEMPERATURE_DISPLAY_MAX, 0,
+ REG_TEMPERATURE },
{"+ 5 V", "V", &sysmon_dspic, NULL, NULL,
- 100, 1000, 0, 0xFFFF, 0xFFFF, 4750, 5250, 0,
- 4750, 5250, 0, 0x12CA},
+ 100, 1000, 0, 0xFFFF, 0xFFFF,
+ VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
+ VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
+ REG_VOLTAGE_5V },
{"+ 5 V standby", "V", &sysmon_dspic, NULL, NULL,
- 100, 1000, 0, 0xFFFF, 0xFFFF, 4750, 5250, 0,
- 4750, 5250, 0, 0x12C6},
+ 100, 1000, 0, 0xFFFF, 0xFFFF,
+ VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX 5250, 0,
+ VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
+ REG_VOLTAGE_5V_STANDBY },
};
static int sysmon_table_size = sizeof(sysmon_table) / sizeof(sysmon_table[0]);
--
1.5.2.4
Best regards,
Sascha Laue
-------- Original-Nachricht --------
> Datum: Wed, 26 Mar 2008 00:18:38 +0100
> Von: Wolfgang Denk <wd@denx.de>
> An: "Sascha Laue" <Sascha.Laue@gmx.biz>
> CC: "Markus Klotzb?cher" <mk@denx.de>, saschalaue at gmx.net, u-boot-users at lists.sourceforge.net, marcel.brasch at liebherr.com
> Betreff: Re: [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
> In message <20080320120557.182790@gmx.net> you wrote:
> > Ups.
> >
> > Best regards
> >
> > Sascha Laue
> >
> > diff -u -r -N u-boot/post/board/lwmon5/sysmon.c
> u-boot-mod/post/board/lwmon=
> > 5/sysmon.c
>
> Sorry, but this patch does not apply:
>
> Applying lwmon5: update dsPIC POST spezification
> .dotest/patch:29: trailing whitespace.
> #define TEMPERATURE_DISPLAY_MAX (+85) /* ?C */
> .dotest/patch:46: trailing whitespace.
> 1, 1, -0x8000, 0x7FFF, 0xFFFF,
> .dotest/patch:48: trailing whitespace.
> 0x8000 + TEMPERATURE_DISPLAY_MIN, 0x8000 +
> TEMPERATURE_DISPLAY_MAX, 0,
> .dotest/patch:54: trailing whitespace.
> 100, 1000, -0x8000, 0x7FFF, 0xFFFF,
> .dotest/patch:56: trailing whitespace.
> 0x8000 + VOLTAGE_5V_MIN , 0x8000 + VOLTAGE_5V_MAX, 0,
> error: patch failed: post/board/lwmon5/sysmon.c:110
> error: post/board/lwmon5/sysmon.c: patch does not apply
> fatal: sha1 information is lacking or useless
> (post/board/lwmon5/sysmon.c).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.
> Patch failed at 0001.
>
>
> Please cleanup the code (whitespace issues), and use git-format-patch
> and git-send-email to post a clean, usable patch.
>
> Thanks.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> A failure will not appear until a unit has passed final inspection.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
2008-04-01 7:56 ` Sascha Laue
@ 2008-04-01 8:10 ` Sascha Laue
2008-04-28 20:41 ` Wolfgang Denk
1 sibling, 0 replies; 11+ messages in thread
From: Sascha Laue @ 2008-04-01 8:10 UTC (permalink / raw)
To: u-boot
Hello Wolfgang,
sorry but it's the first time for me.
I'm so sorry but there is an error in my last mail, let's try again.
we modified the specification for the lwmon5 board dspic POST.
Additionally I have add defines for the temperature- and voltagevalues.
Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
---
post/board/lwmon5/sysmon.c | 39 ++++++++++++++++++++++++++++++---------
1 files changed, 30 insertions(+), 9 deletions(-)
diff --git a/post/board/lwmon5/sysmon.c b/post/board/lwmon5/sysmon.c
--- a/post/board/lwmon5/sysmon.c
index 0cf1cf2..77e7ea2 100644
+++ b/post/board/lwmon5/sysmon.c
@@ -34,9 +34,9 @@
* The test passes when all the following voltages and temperatures
* are within allowed ranges:
*
- * Temperature -40 .. +85 C
- * +5V +4.75 .. +5.25 V
- * +5V standby +4.75 .. +5.25 V
+ * Temperature -40 .. +90 C
+ * +5V +4.50 .. +5.50 V
+ * +5V standby +3.50 .. +5.50 V
*
* LCD backlight is not enabled if temperature values are not within
* allowed ranges (-30 .. + 80). The brightness of backlite can be
@@ -62,6 +62,21 @@ extern int dspic_read(ushort reg, ushort *data);
#define RELOC(x) if (x != NULL) x = (void *) ((ulong) (x) + gd->reloc_off)
+#define REG_TEMPERATURE 0x12BC
+#define REG_VOLTAGE_5V 0x12CA
+#define REG_VOLTAGE_5V_STANDBY 0x12C6
+
+#define TEMPERATURE_MIN (-40) /* C */
+#define TEMPERATURE_MAX (+90) /* C */
+#define TEMPERATURE_DISPLAY_MIN (-35) /* C */
+#define TEMPERATURE_DISPLAY_MAX (+85) /* C */
+
+#define VOLTAGE_5V_MIN (+4500) /* mV */
+#define VOLTAGE_5V_MAX (+5500) /* mV */
+
+#define VOLTAGE_5V_STANDBY_MIN (+3500) /* mV */
+#define VOLTAGE_5V_STANDBY_MAX (+5500) /* mV */
+
typedef struct sysmon_s sysmon_t;
typedef struct sysmon_table_s sysmon_table_t;
@@ -115,16 +130,22 @@ struct sysmon_table_s
static sysmon_table_t sysmon_table[] =
{
{"Temperature", " C", &sysmon_dspic_sgn, NULL, sysmon_backlight_disable,
- 1, 1, -32768, 32767, 0xFFFF, 0x8000-40, 0x8000+85, 0,
- 0x8000-30, 0x8000+80, 0, 0x12BC},
+ 1, 1, -32768, 32767, 0xFFFF,
+ 0x8000 + TEMPERATURE_MIN, 0x8000 + TEMPERATURE_MAX, 0,
+ 0x8000 + TEMPERATURE_DISPLAY_MIN, 0x8000 + TEMPERATURE_DISPLAY_MAX, 0,
+ REG_TEMPERATURE },
{"+ 5 V", "V", &sysmon_dspic, NULL, NULL,
- 100, 1000, 0, 0xFFFF, 0xFFFF, 4750, 5250, 0,
- 4750, 5250, 0, 0x12CA},
+ 100, 1000, 0, 0xFFFF, 0xFFFF,
+ VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
+ VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
+ REG_VOLTAGE_5V },
{"+ 5 V standby", "V", &sysmon_dspic, NULL, NULL,
- 100, 1000, 0, 0xFFFF, 0xFFFF, 4750, 5250, 0,
- 4750, 5250, 0, 0x12C6},
+ 100, 1000, 0, 0xFFFF, 0xFFFF,
+ VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
+ VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
+ REG_VOLTAGE_5V_STANDBY },
};
static int sysmon_table_size = sizeof(sysmon_table) / sizeof(sysmon_table[0]);
--
1.5.2.4
Best regards,
Sascha Laue
-------- Original-Nachricht --------
> Datum: Wed, 26 Mar 2008 00:18:38 +0100
> Von: Wolfgang Denk <wd@denx.de>
> An: "Sascha Laue" <Sascha.Laue@gmx.biz>
> CC: "Markus Klotzb?cher" <mk@denx.de>, saschalaue at gmx.net, u-boot-users at lists.sourceforge.net, marcel.brasch at liebherr.com
> Betreff: Re: [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
> In message <20080320120557.182790@gmx.net> you wrote:
> > Ups.
> >
> > Best regards
> >
> > Sascha Laue
> >
> > diff -u -r -N u-boot/post/board/lwmon5/sysmon.c
> u-boot-mod/post/board/lwmon=
> > 5/sysmon.c
>
> Sorry, but this patch does not apply:
>
> Applying lwmon5: update dsPIC POST spezification
> .dotest/patch:29: trailing whitespace.
> #define TEMPERATURE_DISPLAY_MAX (+85) /* ?C */
> .dotest/patch:46: trailing whitespace.
> 1, 1, -0x8000, 0x7FFF, 0xFFFF,
> .dotest/patch:48: trailing whitespace.
> 0x8000 + TEMPERATURE_DISPLAY_MIN, 0x8000 +
> TEMPERATURE_DISPLAY_MAX, 0,
> .dotest/patch:54: trailing whitespace.
> 100, 1000, -0x8000, 0x7FFF, 0xFFFF,
> .dotest/patch:56: trailing whitespace.
> 0x8000 + VOLTAGE_5V_MIN , 0x8000 + VOLTAGE_5V_MAX, 0,
> error: patch failed: post/board/lwmon5/sysmon.c:110
> error: post/board/lwmon5/sysmon.c: patch does not apply
> fatal: sha1 information is lacking or useless
> (post/board/lwmon5/sysmon.c).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.
> Patch failed at 0001.
>
>
> Please cleanup the code (whitespace issues), and use git-format-patch
> and git-send-email to post a clean, usable patch.
>
> Thanks.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> A failure will not appear until a unit has passed final inspection.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
-------- Original-Nachricht --------
> Datum: Tue, 01 Apr 2008 09:56:46 +0200
> Von: "Sascha Laue" <Sascha.Laue@gmx.biz>
> An: Wolfgang Denk <wd@denx.de>
> CC: u-boot-users at lists.sourceforge.net, marcel.brasch at liebherr.com, mk at denx.de
> Betreff: Re: [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
> Hello Wolfgang,
>
> sorry but it's the first time for me.
> let's try again.
>
> we modified the specification for the lwmon5 board dspic POST.
> Additionally I have add defines for the temperature- and voltagevalues.
>
> Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
> ---
> post/board/lwmon5/sysmon.c | 39 ++++++++++++++++++++++++++++++---------
> 1 files changed, 30 insertions(+), 9 deletions(-)
>
> diff --git a/post/board/lwmon5/sysmon.c b/post/board/lwmon5/sysmon.c
> --- a/post/board/lwmon5/sysmon.c
> index 0cf1cf2..77e7ea2 100644
> +++ b/post/board/lwmon5/sysmon.c
> @@ -34,9 +34,9 @@
> * The test passes when all the following voltages and temperatures
> * are within allowed ranges:
> *
> - * Temperature -40 .. +85 C
> - * +5V +4.75 .. +5.25 V
> - * +5V standby +4.75 .. +5.25 V
> + * Temperature -40 .. +90 C
> + * +5V +4.50 .. +5.50 V
> + * +5V standby +3.50 .. +5.50 V
> *
> * LCD backlight is not enabled if temperature values are not within
> * allowed ranges (-30 .. + 80). The brightness of backlite can be
> @@ -62,6 +62,21 @@ extern int dspic_read(ushort reg, ushort *data);
>
> #define RELOC(x) if (x != NULL) x = (void *) ((ulong) (x) +
> gd->reloc_off)
>
> +#define REG_TEMPERATURE 0x12BC
> +#define REG_VOLTAGE_5V 0x12CA
> +#define REG_VOLTAGE_5V_STANDBY 0x12C6
> +
> +#define TEMPERATURE_MIN (-40) /* C */
> +#define TEMPERATURE_MAX (+90) /* C */
> +#define TEMPERATURE_DISPLAY_MIN (-35) /* C */
> +#define TEMPERATURE_DISPLAY_MAX (+85) /* C */
> +
> +#define VOLTAGE_5V_MIN (+4500) /* mV */
> +#define VOLTAGE_5V_MAX (+5500) /* mV */
> +
> +#define VOLTAGE_5V_STANDBY_MIN (+3500) /* mV */
> +#define VOLTAGE_5V_STANDBY_MAX (+5500) /* mV */
> +
> typedef struct sysmon_s sysmon_t;
> typedef struct sysmon_table_s sysmon_table_t;
>
> @@ -115,16 +130,22 @@ struct sysmon_table_s
> static sysmon_table_t sysmon_table[] =
> {
> {"Temperature", " C", &sysmon_dspic_sgn, NULL,
> sysmon_backlight_disable,
> - 1, 1, -32768, 32767, 0xFFFF, 0x8000-40, 0x8000+85, 0,
> - 0x8000-30, 0x8000+80, 0, 0x12BC},
> + 1, 1, -32768, 32767, 0xFFFF,
> + 0x8000 + TEMPERATURE_MIN, 0x8000 + TEMPERATURE_MAX, 0,
> + 0x8000 + TEMPERATURE_DISPLAY_MIN, 0x8000 + TEMPERATURE_DISPLAY_MAX, 0,
> + REG_TEMPERATURE },
>
> {"+ 5 V", "V", &sysmon_dspic, NULL, NULL,
> - 100, 1000, 0, 0xFFFF, 0xFFFF, 4750, 5250, 0,
> - 4750, 5250, 0, 0x12CA},
> + 100, 1000, 0, 0xFFFF, 0xFFFF,
> + VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
> + VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
> + REG_VOLTAGE_5V },
>
> {"+ 5 V standby", "V", &sysmon_dspic, NULL, NULL,
> - 100, 1000, 0, 0xFFFF, 0xFFFF, 4750, 5250, 0,
> - 4750, 5250, 0, 0x12C6},
> + 100, 1000, 0, 0xFFFF, 0xFFFF,
> + VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX 5250, 0,
> + VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
> + REG_VOLTAGE_5V_STANDBY },
> };
> static int sysmon_table_size = sizeof(sysmon_table) /
> sizeof(sysmon_table[0]);
>
> --
> 1.5.2.4
>
> Best regards,
> Sascha Laue
>
> -------- Original-Nachricht --------
> > Datum: Wed, 26 Mar 2008 00:18:38 +0100
> > Von: Wolfgang Denk <wd@denx.de>
> > An: "Sascha Laue" <Sascha.Laue@gmx.biz>
> > CC: "Markus Klotzb?cher" <mk@denx.de>, saschalaue at gmx.net,
> u-boot-users at lists.sourceforge.net, marcel.brasch at liebherr.com
> > Betreff: Re: [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
>
> > In message <20080320120557.182790@gmx.net> you wrote:
> > > Ups.
> > >
> > > Best regards
> > >
> > > Sascha Laue
> > >
> > > diff -u -r -N u-boot/post/board/lwmon5/sysmon.c
> > u-boot-mod/post/board/lwmon=
> > > 5/sysmon.c
> >
> > Sorry, but this patch does not apply:
> >
> > Applying lwmon5: update dsPIC POST spezification
> > .dotest/patch:29: trailing whitespace.
> > #define TEMPERATURE_DISPLAY_MAX (+85) /* ?C */
> > .dotest/patch:46: trailing whitespace.
> > 1, 1, -0x8000, 0x7FFF, 0xFFFF,
> > .dotest/patch:48: trailing whitespace.
> > 0x8000 + TEMPERATURE_DISPLAY_MIN, 0x8000 +
> > TEMPERATURE_DISPLAY_MAX, 0,
> > .dotest/patch:54: trailing whitespace.
> > 100, 1000, -0x8000, 0x7FFF, 0xFFFF,
> > .dotest/patch:56: trailing whitespace.
> > 0x8000 + VOLTAGE_5V_MIN , 0x8000 + VOLTAGE_5V_MAX, 0,
> > error: patch failed: post/board/lwmon5/sysmon.c:110
> > error: post/board/lwmon5/sysmon.c: patch does not apply
> > fatal: sha1 information is lacking or useless
> > (post/board/lwmon5/sysmon.c).
> > Repository lacks necessary blobs to fall back on 3-way merge.
> > Cannot fall back to three-way merge.
> > Patch failed at 0001.
> >
> >
> > Please cleanup the code (whitespace issues), and use git-format-patch
> > and git-send-email to post a clean, usable patch.
> >
> > Thanks.
> >
> > Best regards,
> >
> > Wolfgang Denk
> >
> > --
> > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> > A failure will not appear until a unit has passed final inspection.
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
2008-04-01 7:56 ` Sascha Laue
2008-04-01 8:10 ` Sascha Laue
@ 2008-04-28 20:41 ` Wolfgang Denk
1 sibling, 0 replies; 11+ messages in thread
From: Wolfgang Denk @ 2008-04-28 20:41 UTC (permalink / raw)
To: u-boot
In message <20080401075646.145810@gmx.net> you wrote:
>
> sorry but it's the first time for me.
> let's try again.
>
> we modified the specification for the lwmon5 board dspic POST.
> Additionally I have add defines for the temperature- and voltagevalues.
>
> Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
> ---
> post/board/lwmon5/sysmon.c | 39 ++++++++++++++++++++++++++++++---------
> 1 files changed, 30 insertions(+), 9 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Committee, n.: A group of men who individually can do nothing but as
a group decide that nothing can be done. - Fred Allen
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
@ 2008-04-30 13:16 Sascha Laue
2008-04-30 19:56 ` Wolfgang Denk
0 siblings, 1 reply; 11+ messages in thread
From: Sascha Laue @ 2008-04-30 13:16 UTC (permalink / raw)
To: u-boot
Hello Wolfgang,
I've found this merge-merge-error.
best regards
Sascha Laue
From: Sascha Laue <sascha.laue@liebherr.com>
Date: Wed, 30 Apr 2008 12:27:21 +0200
Subject: [PATCH] fix manual merge error in lwmon5 posttest.
Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
---
post/board/lwmon5/sysmon.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/post/board/lwmon5/sysmon.c b/post/board/lwmon5/sysmon.c
index 793f670..23cb709 100644
--- a/post/board/lwmon5/sysmon.c
+++ b/post/board/lwmon5/sysmon.c
@@ -132,7 +132,7 @@ static sysmon_table_t sysmon_table[] =
{
"+ 5 V", "V", &sysmon_dspic, NULL, NULL,
- 100, 1000, 0, 0xFFFF, 0xFFFF,
+ 100, 1000, -0x8000, 0x7FFF, 0xFFFF,
VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
REG_VOLTAGE_5V,
@@ -140,7 +140,7 @@ static sysmon_table_t sysmon_table[] =
{
"+ 5 V standby", "V", &sysmon_dspic, NULL, NULL,
- 100, 1000, 0, 0xFFFF, 0xFFFF,
+ 100, 1000, -0x8000, 0x7FFF, 0xFFFF,
VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
REG_VOLTAGE_5V_STANDBY,
--
1.5.2.4
-------- Original-Nachricht --------
> Datum: Mon, 28 Apr 2008 22:41:39 +0200
> Von: Wolfgang Denk <wd@denx.de>
> An: "Sascha Laue" <Sascha.Laue@gmx.biz>
> CC: marcel.brasch at liebherr.com, u-boot-users at lists.sourceforge.net, mk at denx.de
> Betreff: Re: [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
> In message <20080401075646.145810@gmx.net> you wrote:
> >
> > sorry but it's the first time for me.
> > let's try again.
> >
> > we modified the specification for the lwmon5 board dspic POST.
> > Additionally I have add defines for the temperature- and voltagevalues.
> >
> > Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
> > ---
> > post/board/lwmon5/sysmon.c | 39
> ++++++++++++++++++++++++++++++---------
> > 1 files changed, 30 insertions(+), 9 deletions(-)
>
> Applied, thanks.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Committee, n.: A group of men who individually can do nothing but as
> a group decide that nothing can be done. - Fred Allen
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
@ 2008-04-30 13:23 Sascha Laue
2008-04-30 20:29 ` Wolfgang Denk
0 siblings, 1 reply; 11+ messages in thread
From: Sascha Laue @ 2008-04-30 13:23 UTC (permalink / raw)
To: u-boot
Hello Wolfgang,
i found another problem with the sysmon POST.
We have to add an offset to the voltage thresholds.
best regards,
Sascha Laue
From: Sascha Laue <sascha.laue@liebherr.com>
Date: Wed, 30 Apr 2008 13:32:17 +0200
Subject: [PATCH] fix an offset error in lwmon5 sysmon0 post.
---
post/board/lwmon5/sysmon.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/post/board/lwmon5/sysmon.c b/post/board/lwmon5/sysmon.c
index 23cb709..e9c9624 100644
--- a/post/board/lwmon5/sysmon.c
+++ b/post/board/lwmon5/sysmon.c
@@ -133,16 +133,16 @@ static sysmon_table_t sysmon_table[] =
{
"+ 5 V", "V", &sysmon_dspic, NULL, NULL,
100, 1000, -0x8000, 0x7FFF, 0xFFFF,
- VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
- VOLTAGE_5V_MIN, VOLTAGE_5V_MAX, 0,
+ 0x8000 + VOLTAGE_5V_MIN, 0x8000 + VOLTAGE_5V_MAX, 0,
+ 0x8000 + VOLTAGE_5V_MIN, 0x8000 + VOLTAGE_5V_MAX, 0,
REG_VOLTAGE_5V,
},
{
"+ 5 V standby", "V", &sysmon_dspic, NULL, NULL,
100, 1000, -0x8000, 0x7FFF, 0xFFFF,
- VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
- VOLTAGE_5V_STANDBY_MIN, VOLTAGE_5V_STANDBY_MAX, 0,
+ 0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0,
+ 0x8000 + VOLTAGE_5V_STANDBY_MIN, 0x8000 + VOLTAGE_5V_STANDBY_MAX, 0,
REG_VOLTAGE_5V_STANDBY,
},
};
--
1.5.2.4
-------- Original-Nachricht --------
> Datum: Mon, 28 Apr 2008 22:41:39 +0200
> Von: Wolfgang Denk <wd@denx.de>
> An: "Sascha Laue" <Sascha.Laue@gmx.biz>
> CC: marcel.brasch at liebherr.com, u-boot-users at lists.sourceforge.net, mk at denx.de
> Betreff: Re: [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
> In message <20080401075646.145810@gmx.net> you wrote:
> >
> > sorry but it's the first time for me.
> > let's try again.
> >
> > we modified the specification for the lwmon5 board dspic POST.
> > Additionally I have add defines for the temperature- and voltagevalues.
> >
> > Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
> > ---
> > post/board/lwmon5/sysmon.c | 39
> ++++++++++++++++++++++++++++++---------
> > 1 files changed, 30 insertions(+), 9 deletions(-)
>
> Applied, thanks.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Committee, n.: A group of men who individually can do nothing but as
> a group decide that nothing can be done. - Fred Allen
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
2008-04-30 13:16 Sascha Laue
@ 2008-04-30 19:56 ` Wolfgang Denk
0 siblings, 0 replies; 11+ messages in thread
From: Wolfgang Denk @ 2008-04-30 19:56 UTC (permalink / raw)
To: u-boot
In message <20080430131635.311880@gmx.net> you wrote:
> Hello Wolfgang,
>
> I've found this merge-merge-error.
>
> best regards
> Sascha Laue
>
> From: Sascha Laue <sascha.laue@liebherr.com>
> Date: Wed, 30 Apr 2008 12:27:21 +0200
> Subject: [PATCH] fix manual merge error in lwmon5 posttest.
>
> Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
> ---
> post/board/lwmon5/sysmon.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Applied, manually - your patch is white-space corrupted and does not
apply:
Applying lwmon5: fix manual merge error in POST
error: patch failed: post/board/lwmon5/sysmon.c:132
error: post/board/lwmon5/sysmon.c: patch does not apply
Using index info to reconstruct a base tree...
error: patch failed: post/board/lwmon5/sysmon.c:132
error: post/board/lwmon5/sysmon.c: patch does not apply
Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Cannot fall back to three-way merge.
Patch failed at 0001.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The human mind treats a new idea the way the body treats a strange
protein - it rejects it. - P. Medawar
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification
2008-04-30 13:23 Sascha Laue
@ 2008-04-30 20:29 ` Wolfgang Denk
0 siblings, 0 replies; 11+ messages in thread
From: Wolfgang Denk @ 2008-04-30 20:29 UTC (permalink / raw)
To: u-boot
In message <20080430132338.311900@gmx.net> you wrote:
> Hello Wolfgang,
>
> i found another problem with the sysmon POST.
> We have to add an offset to the voltage thresholds.
>
> best regards,
> Sascha Laue
>
> From: Sascha Laue <sascha.laue@liebherr.com>
> Date: Wed, 30 Apr 2008 13:32:17 +0200
> Subject: [PATCH] fix an offset error in lwmon5 sysmon0 post.
>
> ---
> post/board/lwmon5/sysmon.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
Applied, manually again.
Please pay a bit more attention how to submit patches:
- comments that are not intended for the commit message belong *below*
the '---' line
- this patch was again white space corrupted.
I *strongly* recommend to use 'git-send-email' to send patches.
The tools you are using are obviously inadequate.
Thanks in advance.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Alles Gescheite ist schon gedacht worden, man mu? nur versuchen,
es noch einmal zu denken. -- Goethe, Maximen und Reflexionen
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2008-04-30 20:29 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-20 11:54 [U-Boot-Users] [PATCH] lwmon5 dspic POST spezification Sascha Laue
2008-03-20 12:00 ` Markus Klotzbücher
2008-03-20 12:05 ` Sascha Laue
2008-03-25 23:18 ` Wolfgang Denk
2008-04-01 7:56 ` Sascha Laue
2008-04-01 8:10 ` Sascha Laue
2008-04-28 20:41 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2008-04-30 13:16 Sascha Laue
2008-04-30 19:56 ` Wolfgang Denk
2008-04-30 13:23 Sascha Laue
2008-04-30 20:29 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox