[U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function

Ben Warren
2008-03-25T11:11:14Z

On Tue, Mar 25, 2008 at 3:04 AM, Stefan Roese <sr@denx.de> wrote:
> On Saturday 22 March 2008, Ben Warren wrote:
>
> <snip>
>
>
> > > All I'm asking for is to make sure that this can be configured in a
> > > board specific way. If there is a zensible default setting which
> > > covers most cases without need for board-specific stuff that's just
> > > all the better.
> >
> > How about something like this:
> >
> > #ifdef CONFIG_ETH_INIT_DEFAULT
> > CFG_ETH_INIT_DEFAULT(bis);
> > #else
> > board_eth_init(bis);
> > #endif
>
> Using Markus's idea, why not use a cpu (platform) specific *and* a board
> specific init function, both with an empty weak alias in the common eth.c
> code:
>
> cpu_eth_init(bis);
> board_eth_init(bis);
>

Sorry I missed that. Excellent idea.

regards,
Ben