[U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function

Andy Fleming
2008-03-25T16:17:42Z

On Tue, Mar 25, 2008 at 9:22 AM, Ben Warren <biggerbadderben@gmail.com> wrote:
> Stefan Roese wrote:
> > On Saturday 22 March 2008, Ben Warren wrote:

> > Using Markus's idea, why not use a cpu (platform) specific *and* a board
> > specific init function, both with an empty weak alias in the common eth.c
> > code:
> >
> > cpu_eth_init(bis);
> > board_eth_init(bis);
> >
>
> I thought about this some more, and the problem is that cpu_eth_init() and board_eth_init()
> are mutually exclusive, with board_eth_init() having a higher priority.
> I think the following will work, but would appreciate some feedback.

I'm not sure that's necessarily the case. Imagine, for instance, an
85xx board that (for some reason) has on-board ethernet. I believe
some of the DS systems do this. So the 85xx has 4 nics which the SOC
knows how to initialize. But the board has an additional driver to
init. Why not just allow them both?

Andy