[U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function

Stefan Roese
2008-03-25T14:43:14Z

On Tuesday 25 March 2008, Ben Warren wrote:
> I thought about this some more, and the problem is that cpu_eth_init() and
> board_eth_init() are mutually exclusive,

Right.

> with board_eth_init() having a
> higher priority. I think the following will work, but would appreciate some
> feedback.
>
> -----
>
> int board_eth_init(bd_t *bis) __attribute(weak);
> int cpu_eth_init(bd_t *bis) __attribute(weak);
>
> .
> .
> .
>
> if (board_eth_init)
> board_eth_init(bis);
> else if (cpu_eth_init)
> cpu_eth_init(bis);
>
> -----
>
> This gets rid of the pointless aliases and gives precedence to the
> board-specific initialization.

I like it.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================