[U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function

Haavard Skinnemoen
2008-03-26T14:27:51Z

On Wed, 26 Mar 2008 10:15:20 -0400
Ben Warren <biggerbadderben@gmail.com> wrote:

> The
> only thing that might be better is to #include netdev.h in common.h,
> getting rid of the requirement to include it in each board file. OTOH,
> cascading header files is itself an ugly practice.

I think we should try to make common.h smaller, not bigger. Requiring
the board code that does netdev setup to include netdev.h is very
appropriate IMO.

> In an entirely
> biased way, I think the way I've implemented this is a big improvement
> over the status quo and should make things easier going forward.

I completely agree.

Btw, if we require the list of prototypes in netdev.h to be kept in
alphabetical order (or some other sort of "random" order instead of
adding stuff at the end), we might reduce the probability of conflicts
slightly.

Haavard