[U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function

Haavard Skinnemoen
2008-03-26T10:00:12Z

On Sun, 23 Mar 2008 15:19:55 +0900
Shinya Kuribayashi <skuribay@ruby.dti.ne.jp> wrote:

> int board_eth_init(bd_t *bis)
> {
> + extern int tsec_initialize(bd_t * bis, int index, char *devname);

Eww...no, please don't do that. Function prototypes belong in header
files. By adding extern declarations all over the place, the compiler
won't notice if the caller and callee get out of sync.

Having a header file full of driver-specific declarations does increase
the chances of conflicts, but I think it's worth it. It's definitely an
improvement over the old code. And the conflicts will be absolutely
trivial.

Haavard