[U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function

Wolfgang Denk
2008-03-22T14:01:07Z

In message <200803221114.40956.sr@denx.de> you wrote:
>
> > In message <200803220731.23229.sr@denx.de> you wrote:
> > > I would prefer to move this init code not into the board code but into
> > > the platform/cpu code. Speaking for PPC4xx, here all configuration I know
> > > of have the same init code. And copying this into all board ports instead
> > > on one place in the cpu directory seems "imperfect".
> >
> > But the ethernet configuration *is* actually bord dependent. A board
> > may or may not use all the ethernet interfaces present on a
> > processor, or it may have additional network controllers attached for
> > example to the PCI bus, etc.
>
> So you vote for adding this code to more than 80 4xx boards that all would use
> the same code here? I don't like this. I would prefer one instance in the cpu
> directory which could be overridden if needed by a board specific version.

We agree that this should be implemented at the highest possible
level, i. e. with touching as little files as possible.

I just wanted to point out that this is actually a board specific
thing, while you said "all configuration I know of have the same init
code."

All I'm asking for is to make sure that this can be configured in a
board specific way. If there is a zensible default setting which
covers most cases without need for board-specific stuff that's just
all the better.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Old programmers never die, they just become managers.